Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-export EnumIter #14

Closed
tyt2y3 opened this issue Jun 5, 2021 · 8 comments · Fixed by #35
Closed

Re-export EnumIter #14

tyt2y3 opened this issue Jun 5, 2021 · 8 comments · Fixed by #35

Comments

@tyt2y3
Copy link
Member

tyt2y3 commented Jun 5, 2021 •
edited
Loading

Re-export EnumIter such that users don't have to depend on strum directly
https://github.com/SeaQL/sea-orm/blob/master/examples/sqlx-mysql/Cargo.toml#L11

Right now, removing that line would make compilation fail.
@billy1624
Copy link
Member

Check this related issue serde-rs/serde#1465

Perhaps we just implement our own EnumIter?

@tyt2y3
Copy link
Member Author

tyt2y3 commented Jun 10, 2021 •
edited
Loading

Is it possible to include their macro-crate and simply re-export that at macro-crate level?

@billy1624
Copy link
Member

Hmmmm... fail to find the workaround

@tyt2y3
Copy link
Member Author

tyt2y3 commented Jun 28, 2021

Peternator7/strum#57 ?

@billy1624
Copy link
Member

Peternator7/strum#57 ?

This is just re-exporting strum_macros to strum. Not related

What blocking us is that the derive macros in strum_macros uses ::strum

@tyt2y3
Copy link
Member Author

tyt2y3 commented Jun 28, 2021

Leaves us no option other than forking?

@billy1624
Copy link
Member

Perhaps we can open an issue on strum. Might have alternative way of doing this?

@tyt2y3
Copy link
Member Author

tyt2y3 commented Jun 28, 2021

Why not fork it and make a POC first before proposing a change?

@billy1624 billy1624 mentioned this issue Jun 30, 2021
Merged
@tyt2y3 tyt2y3 closed this as completed in #35 Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Re-export strum_macros SeaQL/sea-orm
2 participants
@tyt2y3 @billy1624