Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase test coverage #22

Open
7-of-9 opened this issue May 1, 2019 · 1 comment
Open

Increase test coverage #22

7-of-9 opened this issue May 1, 2019 · 1 comment
Labels
Core Wallet help wanted Extra attention is needed

Comments

@7-of-9
Copy link
Member

7-of-9 commented May 1, 2019

Initial focus is on e2e integration tests; note below on limitations of jest --coverage of worker_threads.

@7-of-9 7-of-9 added the help wanted Extra attention is needed label May 1, 2019
@7-of-9
Copy link
Member Author

7-of-9 commented May 9, 2019

Jest is not producing coverage data for source files referenced indirectly by worker thread invocation (i.e. by new Worker()... followed by postMessage to the worker thread, per the integration tests)

This config in package.json / "jest" causes the files not directly referenced with require() to be collected in ./coverage, but as they are not referenced directly by the tests, the coverage data is still zero.
// "collectCoverageFrom": [
// "/*.{js,jsx}",
// "!
/node_modules/**"
// ]

codecov/codecov-node#129

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Wallet help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant