Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance Shift(s): 684cd2de #4776

Closed
github-actions bot opened this issue May 28, 2022 · 1 comment
Closed

Performance Shift(s): 684cd2de #4776

github-actions bot opened this issue May 28, 2022 · 1 comment
Assignees
Labels
Bot A bot generated issue/pull-request Type: Performance

Comments

@github-actions
Copy link
Contributor

Benchmark comparison has identified performance shifts at

Please review the report below and take corrective/congratulatory action as appropriate 🙂

Performance shift report
       before           after         ratio
     [49a510b3]       [684cd2de]
     <main~1>         <main>    
+      2.11328125         2.859375     1.35  experimental.ugrid.regions_combine.CombineRegionsCreateCube.track_addedmem_create_combined_cube(500)

Generated by GHA run 2399147770

@github-actions github-actions bot added Bot A bot generated issue/pull-request Type: Performance labels May 28, 2022
@pp-mo
Copy link
Member

pp-mo commented May 31, 2022

Unlike timings, these 'addedmem' tests can probably be compared with subsequent runs.
Latest at https://github.com/SciTools/iris/actions/runs/2411695692 shows this test measuring ~3.0Mb both before + after that commit (i.e. difference is insignificant + benchmark passes).
So I think that shows this up as not being significant.

@pp-mo pp-mo closed this as completed May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bot A bot generated issue/pull-request Type: Performance
Projects
None yet
Development

No branches or pull requests

1 participant