Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check sensible units for categorisation functions. #3722

Closed
pp-mo opened this issue May 29, 2020 · 1 comment
Closed

Check sensible units for categorisation functions. #3722

pp-mo opened this issue May 29, 2020 · 1 comment
Milestone

Comments

@pp-mo
Copy link
Member

pp-mo commented May 29, 2020

Following #3713 , default Coord units are now all "unknown".
We need to check functions in iris.coord_categorisation + fix where appropriate :

  • units from the generic add_categorised_coordfunction all default to '1'.
    • this has not changed from previous (Iris v1/2) behaviour
  • all the derived specialised add_xxx functions (year, dayofweek etc) now also need a scan, to ensure the results still make sense, and consistent with new expectations
    • at present, "no unit" is set where needed
    • we may need to change or augment this by setting '1' where appropriate
    • probably safest to state explicitly for every case.
@pp-mo
Copy link
Member Author

pp-mo commented Jun 12, 2020

Checked these, and all ok.

@pp-mo pp-mo closed this as completed Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant