add basic JS support by using custom Tensor replacement #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
The replacement is just a `seq[T]`
Run and compile (using node JS), but should also work in a browser if properly embedded in a file: `nim js -r tests/testdf_js_simple.nim`
a rank proc was required but missing when I tried running the simple test.
This is to match the parsing behavior of C backend strings
For some reason the `unittest` logic of nested templates breaks these. Works fine on devel though (with JS)
41639e2 to
b490b1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The replacement is just a
seq[T].This should be split into multiple commits ideally. Also the changes to
parseNumberare a bit weird. I just made it work quickly and I don't fully understand what's going on. Are strings on the JS backend not zero terminated maybe?There is a new test case
testdf_js_simple, which removes some stuff to make it run. But it passes using nodejs on my machine:CI failure is expected, because I was not exactly careful to not break anything right now.