From 9869784c4a1f9af88aaff3b4e841e65901a6b4c6 Mon Sep 17 00:00:00 2001 From: Aayush Sabharwal Date: Fri, 6 Dec 2024 11:33:02 +0530 Subject: [PATCH 1/2] fix: check if `prob.f.sys` exists before accessing it in `remake` --- src/remake.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/remake.jl b/src/remake.jl index b16476473..d3db11b9c 100644 --- a/src/remake.jl +++ b/src/remake.jl @@ -804,7 +804,7 @@ function updated_u0_p( if u0 === missing && p === missing return state_values(prob), parameter_values(prob) end - if prob.f.sys === nothing + if has_sys(prob.f) && prob.f.sys === nothing if interpret_symbolicmap && eltype(p) !== Union{} && eltype(p) <: Pair throw(ArgumentError("This problem does not support symbolic maps with " * "`remake`, i.e. it does not have a symbolic origin. Please use `remake`" * From 9d0e938a570bd9ed7a957818130213c5f0e5adb2 Mon Sep 17 00:00:00 2001 From: Aayush Sabharwal Date: Fri, 6 Dec 2024 11:40:40 +0530 Subject: [PATCH 2/2] test: mark some tests as no longer broken --- test/downstream/problem_interface.jl | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/downstream/problem_interface.jl b/test/downstream/problem_interface.jl index 1a500ebcf..91ceae31b 100644 --- a/test/downstream/problem_interface.jl +++ b/test/downstream/problem_interface.jl @@ -261,12 +261,12 @@ eprob = EnsembleProblem(oprob) @test eprob.ps[osys.p] == 0.1 @test state_values(remake(eprob; u0 = [X => 0.1])) == [0.1] -@test_broken state_values(remake(eprob; u0 = [:X => 0.2])) == [0.2] +@test state_values(remake(eprob; u0 = [:X => 0.2])) == [0.2] @test state_values(remake(eprob; u0 = [osys.X => 0.3])) == [0.3] -@test_broken remake(eprob; p = [d => 0.4]).ps[d] == 0.4 -@test_broken remake(eprob; p = [:d => 0.5]).ps[d] == 0.5 -@test_broken remake(eprob; p = [osys.d => 0.6]).ps[d] == 0.6 +@test remake(eprob; p = [d => 0.4]).ps[d] == 0.4 +@test remake(eprob; p = [:d => 0.5]).ps[d] == 0.5 +@test remake(eprob; p = [osys.d => 0.6]).ps[d] == 0.6 # SteadyStateProblem Indexing # Issue#660