Add Graph tests

[isaacsas]

I think we will also need a Graph call update for an API change on Catlab master soon as in:

https://github.com/mehalter/Petri.jl/pull/32/files

[isaacsas]

Test from #242

Still need to update Graph syntax for after a new Catlab release is made.

[isaacsas]

Can't add tests due to needing a commandline Graphviz install.

[ChrisRackauckas]

Maybe @christopher-dG can look into building an artifact for that. Catlab.jl should really ship with the binary (@jpfairbanks)

[jpfairbanks]

I don’t know how to make that work, but given binary builder’s reputation it seems possible. What do we need to do to make it happen?

[ChrisRackauckas]

Someone who knows a bit of binary magic.

[isaacsas]

That would be great to have, and would help us both with CI.

[isaacsas]

If binary builder proves problematic, another option is it appears available through Anaconda. Maybe it can be pulled in using Conda.jl?

[ChrisRackauckas]

Conda is scary and leads to maintenance issues over time. I'd 100% try to avoid that if possible.

[christopher-dG]

I'll have a crack at building it with BB today. Looks straightforward unless there are some dependencies we don't yet have.

[jpfairbanks]

Awesome I’ll ping @epatters to make sure he is on the lookout for any Catlab PRs

[christopher-dG]

Wait... Graphviz_jll is already a thing. Have you guys tried that?

[ChrisRackauckas]

fastest binary building in the west!

[jpfairbanks]

It wasn’t working/sustainable at the time we adopted the current set up. Not sure if that has changed. I’d be happy to modernize that if necessary/feasible

[christopher-dG]

What was wrong with it?

[jpfairbanks]

We’ll have to wait for the west coast to wake up to ask Evan :)

[isaacsas]

@jpfairbanks Having not used jll's before I found this helpful:

https://github.com/JuliaBinaryWrappers/Graphviz_jll.jl

[isaacsas]

Maybe the issue is that Catlab wants to call more of the executables than are wrapped? It seems to want to call any of:

"dot","neato","fdp","sfdp","twopi","circo"

see

https://github.com/AlgebraicJulia/Catlab.jl/blob/7c0313f011d6178433a76c05d64eb138da1330c9/src/graphics/Graphviz.jl#L121

[christopher-dG]

I just ran Graphviz's build_tarballs.jl manually and it does build all of those executables, they just aren't declared as products for the wrapper. I can update the build script to include all of those products.

Here's the full list of new files in $bindir after building Graphviz:

acyclic
bcomps
ccomps
circo
cluster
dijkstra
dot
dot2gxl
dot_builtins
edgepaint
fdp
gc
gml2gv
graphml2gv
gv2gml
gv2gxl
gvcolor
gvgen
gvmap
gvmap.sh
gvpack
gvpr
gxl2dot
gxl2gv
mm2gv
neato
nop
osage
patchwork
prune
sccmap
sfdp
tred
twopi
unflatten

[isaacsas]

Awesome, thanks for updating that! Hopefully with that change it will be a small tweak to the Catlab open call here

https://github.com/AlgebraicJulia/Catlab.jl/blob/7c0313f011d6178433a76c05d64eb138da1330c9/src/graphics/Graphviz.jl#L122

to get this working now.

[epatters]

So the history is: originally I used GraphViz.jl, which provides bindings to the Graphviz C API, but it became unmaintained and I couldn't port it myself, so then I switched to just calling Graphviz through its CLI, assuming that the user had it installed.

Great to hear that somebody has built Graphviz using BinaryBuilder! Looks like its only a few months old. Once it supplies all the right binaries we can definitely switch to that at Catlab.

[christopher-dG]

Nice, I'll get that PR up to Yggdrasil shortly.

[giordano]

Looks straightforward

😂 😂 JuliaPackaging/Yggdrasil#351 has been open for 5 months, look at the patches 😂 And it doesn't even build for Windows because the entire Graphviz is completely messed up

[christopher-dG]

Yeah... I may have choked a bit when I saw the existing builder 😅

[isaacsas]

@christopher-dG @giordano Thanks for all your help with this! With the new jll setup this will fix our issues here.