-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export sparsity detection interface #82
Comments
sounds fine to me. |
I'll open a PR if @gdalle doesn't object. |
Marked as public, definitely, but that would require bringing Compat as an additional dependency since the public keyword only lands in Julia 1.11. Exports are essentially useless because they don't semantically denote public API, they just clutter the namespace. I would be okay with exporting the first two, but no one is ever gonna use the latter two in their code so I'm firmly against exporting those. |
On second thought it's not a great idea to export using ADTypes, Symbolics will be broken |
Symbolics should extend. |
Unclear because the Symbolics functions apply to different data types (symbolic variables and expressions) |
The interface for sparsity detection should be exported, or at least marked as
public
.The exported symbols are very unlikely to cause name collisions:
jacobian_sparsity
hessian_sparsity
AbstractSparsityDetector
NoSparsityDetector
The same applies to the matrix coloring interface as well.
The text was updated successfully, but these errors were encountered: