Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent reporting of http error messages #11

Open
dylanmcreynolds opened this issue Mar 15, 2022 · 0 comments
Open

Inconsistent reporting of http error messages #11

dylanmcreynolds opened this issue Mar 15, 2022 · 0 comments

Comments

@dylanmcreynolds
Copy link
Member

The ScicatClient class has an inconsistent reporting of error messages.

Some methods, like upload_raw_dataset raises a ScicatCommError whose message is the str Scicat's err response.

Others, like get_datasets, return none and log to the logger.

I prefer raising ScicatCommError, but would like to see it be more specific, containing fields for the code and message.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dylanmcreynolds