Merge V25.2.1 into main #1571
Closed
Merge V25.2.1 into main #1571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: BryanFauble <17128019+BryanFauble@users.noreply.github.com>
* [FDS-2386] Synapse entity tracking and code concurrency updates
Update CODEOWNERS
…bute-unit-tests Fds 2333 validate attribute unit tests
…Path module for checking cache size (#1542) * Add version to click cli * Add version * Run black * Reformat * Fix * Update schematic/schemas/data_model_parser.py * Add test for check_synapse_cache_size * Reformat * Fix tests * Remove unused parameter * Install all-extras for now * Make otel flash non-optional * Update dockerfile * Add dependencies as non-optional * Update pyproject toml * Fix trivy issue * Add service version * Run black * Move all utils.general tests into separate folder * Use pre-commit * Add updates to contribution doc * Fix * Add service version to log provider --------- Co-authored-by: BryanFauble <17128019+BryanFauble@users.noreply.github.com>
* Set instance id in github CI run, uninstrument flask auto during integration test run
…ne doesn't have `entityId` (#1551) * adds error handling * adds unit tests for _get_file_entityIds * updates error message * adds entityid check to parent func * updates docstring
source manifest file paths from synapse fileviews at generation
… with the NA values argument (#1553) * Wrap pandas functions to support not including `None` with the NA values argument * Ignore types * pylint issues * ordering of ignore * Add to integration test to cover none in a manifest * Add additional test for manifest * [SCHEMATIC-210] Add attribute to nones data model (#1555) Update example_test_nones.model.csv component and add new invalid manifest with nones * first commit * ran black * add test for validateModelManifest * [SCHEMATIC-214] change data model and component (#1556) * add valid values to Patient attributes * update data model * add test manifests * update test for new model * update test for new valid value * change test to use new manifests * remove uneeded test file * revert file * revert file * change tests to use new manifests * remove uneeded manifests * ran black * add tests back in * ran black * revert manifest * Split up valid and errored test as separate testing functions * Remove unused import --------- Co-authored-by: Gianna Jordan <61707471+GiaJordan@users.noreply.github.com> Co-authored-by: Andrew Lamb <andrewelamb@gmail.com> Co-authored-by: Thomas Yu <thomas.yu@sagebase.org>
… (#1560) * [SCHEMATIC-210] Updates `publish.yml` for Test PyPi deployments (#1559) * updates pypi publishing workflow * specify python version explicitly * list dist/ * throw error if no files * Update publish.yml * Update publish.yml * test * undo test * test build * test full build * debug prerelease * full debug print * reverse logic * use boolean true * try publish * adds test url * override_version * updates version * manually edit version * add back slack and revert version * lock ubuntu version * addresses lingling comments
* Add precommit * Use pre-commit * Run precommit * Add EOL
…xporting to signoz cloud (#1565) * update readme instructions * signoz cloud link update * ensure environment variable gets loaded * move python-dotenv to regular dependencies * add instructions on configuring environment variables
* attempt to update sonarcloud scan action * temp remove change to integration test * temp remove all integration tests * update Scan version, do debug * remove sed command * add back in integration tests, remove debug param
* remove replace table test * reduce number of folders to copy in test manifest
* add a custom class to propagate attributes * propogate user id to all children of SynapseStorage::__init__ * add code to paste attribute from child back to parent * move security controller to utils * fix mypy error * fix pylint error * use syn.credentials.owner_id to get user id * add back lines in request_hook * switch order of processor * correct the import statement * add docstring * move security controller back to the old location
… library and CLI usage (#1569) set synapseclient user strings to track schematic cli and library usage
BryanFauble
approved these changes
Feb 3, 2025
thomasyu888
requested changes
Feb 3, 2025
There was a problem hiding this comment.
Please make sure to follow the new SOP here: https://sagebionetworks.jira.com/wiki/spaces/SCHEM/pages/3679911937/Schematic+Release+Branch+workflow
- Make sure to update the version
- create a release candidate tag (pre release)
pushing to main comes a bit further done the line
|
|
Close this PR because we would need to open a PR from v25.2.2-rc-dev instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.