Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test_get_manifest_with_files to match changes on synapse #1473

Closed
wants to merge 1 commit into from
Closed

Update test_get_manifest_with_files to match changes on synapse #1473

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/test_manifest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -798,4 +798,4 @@ def test_get_manifest_with_files(self, helpers, component, datasetId):
assert n_rows == 4
elif component == "BulkRNA-seqAssay":
assert filename_in_manifest_columns
assert n_rows == 3
assert n_rows == 4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Does it make sense to map to specific fileview snapshot version so that this doesn't happen?

In the long term future, it would be helpful to think about tests with setup and teardown methods so that they are stable.

Copy link
Member

@thomasyu888 thomasyu888 Aug 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall concern is that you want to know explicitly why a test failed. It's not ideal to have to figure out that the test failing is due to something updated on Synapse not directly related to the code.

But, that can be a separate ticket! Thanks for the great work here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I completely agree with what Tom said. I could create a separate ticket for this: https://sagebionetworks.jira.com/browse/FDS-2306, and this would be a good way to drive to cleaner and more organized code.

Loading