Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug fix] Renamed function related to setting background color of required columns #1276

Merged
merged 2 commits into from
Aug 15, 2023
Merged

[bug fix] Renamed function related to setting background color of required columns #1276

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00ecf41
rename function
linglp Jul 31, 2023
074f4b7
edit comment
linglp Jul 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions schematic/manifest/generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -886,7 +886,7 @@ def _request_note_valid_values(self, i, req, validation_rules, valid_values):
else:
return

def _request_notes_comments(self, i, req, json_schema):
def _set_required_columns_color(self, i, req, json_schema):
"""Update background colors so that columns that are required are highlighted
Args:
i (int): column index
Expand Down Expand Up @@ -1126,10 +1126,10 @@ def _create_requests_body(
if get_row_formatting:
requests_body["requests"].append(get_row_formatting)

# Add notes to headers to provide descriptions of the attribute
header_notes = self._request_notes_comments(i, req, json_schema)
if header_notes:
requests_body["requests"].append(header_notes)
# set color of required columns to blue
required_columns_color = self._set_required_columns_color(i, req, json_schema)
if required_columns_color:
requests_body["requests"].append(required_columns_color)
# Add note on how to use multi-select, when appropriate
note_vv = self._request_note_valid_values(
i, req, validation_rules, valid_values
Expand Down