Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation passed, but disconnected during submission #393

Closed
1 of 3 tasks
rrchai opened this issue Aug 26, 2022 · 1 comment
Closed
1 of 3 tasks

Validation passed, but disconnected during submission #393

rrchai opened this issue Aug 26, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@rrchai
Copy link
Contributor

rrchai commented Aug 26, 2022

Describe the bug

We set the restrict_rules=True in the validation to avoid the conflicts between the reticulate of R and great_expectation of python, but we haven't added the restrictions for the submission related functions in DCA. It could be the reason why the validation passed, but submission failed. See the example below:

There are two different validation results with or without -rr (restrict_rules) flag

  1. schematic model -c schematic_config.yml validate -mp Untitled.spreadsheet.-.HTA9.OHSU.HTAN.Imaging.Level.2.-.Sheet1.2.2.csv -dt ImagingLevel2:
error: On row 1 the attribute FOV number does not contain the proper value type int.
...
error: On row 110 the attribute FOV number does not contain the proper value type int.
  1. schematic model -c schematic_config.yml validate -mp Untitled.spreadsheet.-.HTA9.OHSU.HTAN.Imaging.Level.2.-.Sheet1.2.2.csv -dt ImagingLevel2 -rr
Great Expetations suite will not be utilized.
Your manifest has been validated successfully. There are no errors in your manifest, and it can be submitted without any modifications.

To Reproduce
see the issue

Expected behavior
The validation behaviors should be matched with what in the submission process.

Priority (select one)

  • Minor ⬇️
  • Major 📢
  • Critical 🆘

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (if applicable, please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@rrchai rrchai added the bug Something isn't working label Aug 26, 2022
@rrchai rrchai self-assigned this Aug 26, 2022
@rrchai
Copy link
Contributor Author

rrchai commented Sep 7, 2022

The issue was actually due to submit the mixed type column as table. Check more details in this schematic ticket. Closing this ticket since the restriction rules have been implemented in submission functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant