Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow playback rate change not immediately applied after having moved away from the live edge #117

Closed
defagos opened this issue Apr 14, 2022 · 1 comment
Milestone

Comments

@defagos
Copy link
Member

defagos commented Apr 14, 2022

After having moved away from the live edge changing the playback rate to a value < 1 should be immediate (unlike values > 1 for which the current value needs to be preserved in some area near the live edge).

Issue type

Incorrect behavior

Environment information

  • Library version: 7.0.0
  • iOS / tvOS version: Any
  • Device: Any

Reproducibility

Always reproducible

Steps to reproduce

  1. Open the demo project.
  2. Play Livestream with DVR sample using the advanced custom player.
  3. Seek 15 seconds in the past.
  4. Change the playback rate to 0.5x. The rate is said to be limited to 1x though this is unnecessary, either briefly or for a longer while. The effective playback rate incorrectly stays at 1x while the message is displayed.
@defagos
Copy link
Member Author

defagos commented Apr 14, 2022

We were already testing playback rate stability, but not in the case described above (starting at the edge with rate 1x, moving a bit in the past, then changing to another rate).

I added two corresponding test cases for slow and fast playback speeds and improved the implementation so that they both pass. This fixes the above reported issue.

Available for review on feature/playback-speed-fix.

@defagos defagos added this to the 7.0.1 milestone Apr 14, 2022
@pyby pyby closed this as completed Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants