Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS 14 leak conflicts with modal presentation at application launch #100

Closed
defagos opened this issue Jan 4, 2021 · 2 comments
Closed
Milestone

Comments

@defagos
Copy link
Member

defagos commented Jan 4, 2021

If an application using SRG Media Player and presents a modal at startup, this might interfere with the trick used to fix iOS 14 leak (see #93).

@defagos
Copy link
Member Author

defagos commented Jan 4, 2021

A fix attempt has been made on feature/pip-fix-improvement. It seems to work but requires more careful testing and investigation.

@pyby pyby added this to the 6.1.2 milestone Jan 4, 2021
@pyby
Copy link
Member

pyby commented Jan 4, 2021

It sounds a good proposition.
The dispatch_after still required to apply the workaround.

Tested in iOS 14.2 and 14.3, iPadOS 14.2 and 14.3.
The leak issue is always reproductible with iOS 14.2 and 14.3 on a device (iPhone XS in my case).

@oiledCode should give us his feedback too.

@pyby pyby closed this as completed Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants