Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #180 changes not appearing on npm install kafka-node #195

Closed
lsampathreddy opened this issue Apr 13, 2015 · 6 comments
Closed

Issue #180 changes not appearing on npm install kafka-node #195

lsampathreddy opened this issue Apr 13, 2015 · 6 comments

Comments

@lsampathreddy
Copy link

Hi Team,
Today i noticed issue #180 changes were not seems to be appeared in kafka-node. after looking in to the myProject/node_module/kafk-node, supprisingly ../lib/client.js missed code related to #180 . it shouldn't happen. could you check ASAP. its very urgent as we are moving to production soon.

Thanks
Sampath

@lsampathreddy lsampathreddy changed the title Issue #180 changes not appearing on npm instal kafka-node Issue #180 changes not appearing on npm install kafka-node Apr 13, 2015
@haio
Copy link
Member

haio commented Apr 14, 2015

Did you reinstall it with npm?

@lsampathreddy
Copy link
Author

@haio
Yes. I reinstalled multiple times. #180 changes were not there in 0.2.24 version.
When i install latest version of kafka-node i.e. 0.2.25, intermittently #180 changes are appearing( i did multiple npm install kafka-node)...

i tried with delete require['kafka-node'] to make sure not to fetch module from cache. but issue still exists.

@haio
Copy link
Member

haio commented Apr 15, 2015

@lsampathreddy I have seen the same issue! The publish time of version 0.2.24 is 2015-03-20T09:29:19.533Z, I can't figure out why the changes is not in this version. You should use kafka-node@0.2.25.

@lsampathreddy
Copy link
Author

Thanks for your response @haio
Was it a npm repo issue? i'm sure i saw #180 changes in 0.2.24 and i tested it couple of days back. but then later i saw changes these were missing in 0.2.24 version... it sounds weird but i'm clueless

@haio
Copy link
Member

haio commented Apr 15, 2015

It's strange for me too, just can't reproduce it.

@haio
Copy link
Member

haio commented Apr 28, 2015

Close.

@haio haio closed this as completed Apr 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants