Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: fiori/BarcodeScannerDialog capture video image from centered region only #8918

Closed
1 task done
slin-sap opened this issue May 8, 2024 · 4 comments
Closed
1 task done

Comments

@slin-sap
Copy link
Contributor

slin-sap commented May 8, 2024

Feature Request Description

Current implementation seems to pass the entire image captured by camera to zxing. This might lead to an unexpected nearby barcode label to be capture instead.

Proposed Solution

It is better to show a focused region like this example screenshot. Or something similar to UI5 sap.ndc.BarcodeScanner animated scanning css effect. This can help user to position camera so that the barcode label fits within the centered region.

Screenshot 2024-05-08 at 8 34 35 AM

In the code, only the centered region needs to be draw to image canvas, and pass to zxing for barcode recognition.

This might require capturing video frame as image as done in sap.ndc.BarcodeScanner and then use codeReader.decodeFromImage API instead of decodeFromVideo.

https://github.com/zxing-js/library/blob/master/docs/examples/barcode-image/index.html

Proposed Alternatives

No response

Organization

UX Engineering

Additional Context

No response

Priority

Medium

Privacy Policy

  • I’m not disclosing any internal or sensitive information.
@niyap
Copy link
Contributor

niyap commented May 9, 2024

Hello @SAP/ui5-webcomponents-topic-p ,

Could you please take a look of this feature request?

Thank you in advance!

Kind Regards,
Niya

@niyap niyap removed their assignment May 9, 2024
@dobrinyonkov dobrinyonkov self-assigned this May 9, 2024
@jdichev
Copy link

jdichev commented May 14, 2024

Team will look into this request. Internal reference: BGSOFUIPIRIN-6561

@dobrinyonkov
Copy link
Contributor

POC: #9259

@dobrinyonkov dobrinyonkov added this to the 2.0.0 milestone Jun 21, 2024
@petyabegovska petyabegovska moved this to In Progress in Planning - Topic P Jun 21, 2024
@ilhan007 ilhan007 modified the milestones: 2.0.0, 2.1.0 Jul 3, 2024
@dobrinyonkov dobrinyonkov modified the milestones: 2.1.0, 2.2.0 Jul 31, 2024
@dobrinyonkov dobrinyonkov modified the milestones: 2.2.0, 2.3.0 Sep 2, 2024
@dobrinyonkov dobrinyonkov modified the milestones: 2.3.0, 2.4.0 Oct 16, 2024
@dobrinyonkov
Copy link
Contributor

Merged with #9646

@github-project-automation github-project-automation bot moved this from In Progress to Completed in Planning - Topic P Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Completed
Development

No branches or pull requests

5 participants