Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NotificationListItem doesn't follow Fiori Design Guideline #2176

Closed
lenient opened this issue Sep 3, 2020 · 3 comments
Closed

NotificationListItem doesn't follow Fiori Design Guideline #2176

lenient opened this issue Sep 3, 2020 · 3 comments
Assignees

Comments

@lenient
Copy link

lenient commented Sep 3, 2020

Describe the bug
If you look at the sample of NotificationListItem and compare it with the description of Notifications of Fiori Design Guideline, you see that there are a few different places.

  • The position of Operation isn't aligned with the Headline.
  • There's no vertical indicator on the left for Priority property.
  • There isn't a horizontal line between the Headline and Subtitle of NotificationListItem, but it's there from the mockup of the Fiori Guideline.

Isolated example
Refer to sample of NotificationListItem

Expected behavior
The NotificationListItem should follow the description of the Fiori Design Guideline.

Screenshots
image

Context

  • UI5 Web Components version: v1.0.0-rc.8
@ilhan007 ilhan007 self-assigned this Sep 3, 2020
@ilhan007
Copy link
Member

ilhan007 commented Sep 3, 2020

Hello @lenient

  • There's no vertical indicator on the left for Priority property.
    Actually the vertical line is the older design, it is replaced by icon indicator, place on the left side of the heading.

You can refer to the sample of the openui5 equivalent control:
https://openui5nightly.hana.ondemand.com/entity/sap.m.NotificationListItem/sample/sap.m.sample.NotificationListItem

The newest VD suggests (unfortunately the https://experience.sap.com/ has not been updated):

Screenshot 2020-09-03 at 7 28 23 AM

  • There isn't a horizontal line between the Headline and Subtitle
    Same

  • The position of Operation (I guess you men the action) isn't aligned with the Headline.

If you hover the button, you will notice that it is aligned perfectly, as it is bigger than the X you see.
Screenshot 2020-09-03 at 7 37 31 AM

@ilhan007 ilhan007 closed this as completed Sep 3, 2020
@lenient
Copy link
Author

lenient commented Sep 3, 2020

@ilhan007 I'm fine with the first two items. But for the #3, as an end-user, I just see the Close button is lower than the Headline.

@ilhan007
Copy link
Member

ilhan007 commented Sep 3, 2020

@lenient would not you see the button misaligned when you hover and press it from end user perspective. I will forward you feedback anyway to the reaponsible Visual Design team, but currently it is by design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants