Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui5-view-settings-dialog] missing type, active state and group header announcements #10297

Open
1 task done
unazko opened this issue Dec 3, 2024 · 3 comments · May be fixed by #10561
Open
1 task done

[ui5-view-settings-dialog] missing type, active state and group header announcements #10297

unazko opened this issue Dec 3, 2024 · 3 comments · May be fixed by #10561

Comments

@unazko
Copy link
Contributor

unazko commented Dec 3, 2024

Bug Description

Hello colleagues,

There is a missing type, active state and group header announcements for the filter by list.
For the sort by and sort order there is a missing type and group header announcements as well.
The issue is reproducible via the following sample: https://sap.github.io/ui5-webcomponents/components/fiori/ViewSettingsDialog/

For comparison checkout the sap.m.ViewSettingsDialog control: https://ui5.sap.com/#/entity/sap.m.ViewSettingsDialog/sample/sap.m.sample.ViewSettingsDialog

Affected Component

ui5-list, ui5-view-settings-dialog

Expected Behaviour

The sort by, sort order and filter by list items should have the following additional announcements:

  1. Type announcements - "List Item"
  2. Active state announcement - "Is active"
  3. Group header announcement - "Sort by" or "Sort Order" or "Filter by"

Isolated Example

https://sap.github.io/ui5-webcomponents/components/fiori/ViewSettingsDialog/

Steps to Reproduce

For the sort by and sort order lists:

  1. Exit JAWS VPC mode
  2. Navigate to the "Open ViewSettingsDialog" button and press "Space"
  3. Press "Arrow down" to navigate to the "Ascending" sort order option

Observe that the type and group header information isn't announced.

For the filter by list:

  1. Exit JAWS VPC mode
  2. Navigate to the "Open ViewSettingsDialog" button and press "Space"
  3. Press "Shift" + "Tab" to navigate over the filter icon
  4. Press "Space" to active the filter view
  5. Press "Tab" to navigate to the filter by group header
  6. Press "Arrow down" to navigate to the "Position" filter by option

Observe that the type, active state and group header information isn't announced.

Log Output, Stack Trace or Screenshots

No response

Priority

Medium

UI5 Web Components Version

latest

Browser

Chrome

Operating System

Windows

Additional Context

Organization

Success Factors

Declaration

  • I’m not disclosing any internal or sensitive information.
@unazko unazko added bug This issue is a bug in the code Medium Prio TOPIC B SAP SF SF_ACC labels Dec 3, 2024
@unazko unazko self-assigned this Dec 3, 2024
@unazko
Copy link
Contributor Author

unazko commented Dec 3, 2024

Hello @SAP/ui5-webcomponents-topic-b,

This issue is for us to fix.

Best regards,
Boyan

@unazko unazko moved this from New Issues to In Progress in Maintenance - Topic B Dec 3, 2024
@unazko unazko added TOPIC P and removed TOPIC B labels Dec 5, 2024
@unazko unazko removed their assignment Dec 5, 2024
@unazko
Copy link
Contributor Author

unazko commented Dec 5, 2024

Hello @SAP/ui5-webcomponents-topic-p,

This bug report is related to the following discussion topic: #10191

After looking at the missing announcements in more detail I've came to the conclusion that they're
coming from the ui5-list component.

The same is also reproducible via the ui5-list component in the following sample:
https://sap.github.io/ui5-webcomponents/components/List/

Please check out the samples for "Single select mode" and the "Grouping".

The default ui5-li's type property value is Active. Nevertheless there is no "Is Active" announcement.
Also the semantic type of the list item's is not announced.

For a ui5-list with a ui5-li-group item and ui5-li items there no group header announcement for the ui5-li elements.
I saw there is a invisible span element defined in the ListItem.hbs file, but the span usually doesn't contain any labelling text.

Could you please check out those announcement issues.

Best regards,
Boyan

@yanaminkova
Copy link
Member

Internal reference: BGSOFUIPIRIN-6285

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

2 participants