Skip to content

Commit 772ac29

Browse files
authoredFeb 29, 2024
[BREAKING] Rename ui5HomeDir to ui5DataDir in APIs (#687)
BREAKING CHANGE: `@ui5/project`'s Installers' and Resolvers' argument `ui5HomeDir` is now renamed to `ui5DataDir` JIRA: CPOUI5FOUNDATION-802 Relates to: SAP/ui5-tooling#701 Depends on: SAP/ui5-project#707
1 parent 6a8c7a6 commit 772ac29

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed
 

‎lib/framework/utils.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -37,15 +37,15 @@ export async function createFrameworkResolverInstance({frameworkName, frameworkV
3737
return new Resolver({
3838
cwd,
3939
version: frameworkVersion,
40-
ui5HomeDir: await utils.getUi5DataDir({cwd})
40+
ui5DataDir: await utils.getUi5DataDir({cwd})
4141
});
4242
}
4343

4444
export async function frameworkResolverResolveVersion({frameworkName, frameworkVersion}, {cwd}) {
4545
const Resolver = await utils.getFrameworkResolver(frameworkName, frameworkVersion);
4646
return Resolver.resolveVersion(frameworkVersion, {
4747
cwd,
48-
ui5HomeDir: await utils.getUi5DataDir({cwd})
48+
ui5DataDir: await utils.getUi5DataDir({cwd})
4949
});
5050
}
5151

‎test/lib/framework/utils.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ test.serial("createFrameworkResolverInstance: Without ui5DataDir", async (t) =>
177177
{
178178
cwd: "my-project-path",
179179
version: "<framework-version>",
180-
ui5HomeDir: undefined
180+
ui5DataDir: undefined
181181
}
182182
]);
183183
});
@@ -217,7 +217,7 @@ test.serial("createFrameworkResolverInstance: With ui5DataDir", async (t) => {
217217
{
218218
cwd: "my-project-path",
219219
version: "<framework-version>",
220-
ui5HomeDir: "my-ui5-data-dir"
220+
ui5DataDir: "my-ui5-data-dir"
221221
}
222222
]);
223223
});
@@ -246,7 +246,7 @@ test.serial("frameworkResolverResolveVersion", async (t) => {
246246
"latest",
247247
{
248248
cwd: "my-project-path",
249-
ui5HomeDir: undefined
249+
ui5DataDir: undefined
250250
}
251251
]);
252252
});

0 commit comments

Comments
 (0)