Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token: Are readOnly tokens supposed to be closeable? #1251

Open
Jonasdoubleyou opened this issue Oct 28, 2020 · 1 comment
Open

Token: Are readOnly tokens supposed to be closeable? #1251

Jonasdoubleyou opened this issue Oct 28, 2020 · 1 comment

Comments

@Jonasdoubleyou
Copy link

The Fundamental Styles Documentation suggests that readonly tokens are supposed to not have a close button, however Fundamental React tokens always have a close button, no matter whether they are readonly or not.

I guess one of the following actions could be taken:

  1. Hide the close button if the onClick parameter is not present (this might change existing UI, but I guess a button that can't be clicked shouldn't look like a button after all).

  2. Hide the close button if the readOnly parameter is present, however the onClick handler is useless in that case.

  3. Introduce another parameter with which the close button can be hidden

I currently just worked around it by using fundamental-styles directly, however I thought this might be worth fixing, so that's why I opened this ticket (so this is very low priority).

Reproduced with fundamental-react:0.9.0, but it seems the component didn't change much throughout the last few versions.

@github-actions
Copy link

Hello @Jonasdoubleyou, thank you for using fundamental-react! The fundamental-react team will triage your issue as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant