Skip to content

Commit a9f9920

Browse files
update parse.yaml to consider tag (#13)
1 parent 3907ea8 commit a9f9920

6 files changed

+14
-8
lines changed

CHANGELOG.md

+6
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,12 @@
33

44
All notable changes to this project will be documented in this file.
55

6+
## Version 0.2.3 - 2024-07-30
7+
8+
### Fixed
9+
10+
- Pack command respects image tag
11+
612
## Version 0.2.2 - 2024-06-19
713

814
### Added

lib/parse_yaml.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,8 @@ function processBuildpack(build_parameters, name, tag) {
4848
if (builders.has(builder)){
4949
builder = `paketobuildpacks/${builder}`
5050
}
51-
52-
const imageCmd = appendSubcommand(name, native_commands.build);
51+
const imageNameWtihTag = `${name}:${tag}`;
52+
const imageCmd = appendSubcommand(imageNameWtihTag, native_commands.build);
5353
const pathCmd = appendSubcommand(path, native_commands.path);
5454
const buildpackCmd = []
5555
type.forEach(type => {

test/expected/build.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
[
88
"pack",
99
"build",
10-
"bookshop-approuter",
10+
"bookshop-approuter:v1",
1111
"--path",
1212
"app",
1313
[
@@ -39,7 +39,7 @@
3939
[
4040
"pack",
4141
"build",
42-
"book-srv",
42+
"book-srv:latest",
4343
"--path",
4444
".",
4545
[

test/expected/buildWithoutBuilder.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
[
88
"pack",
99
"build",
10-
"bookshop-approuter",
10+
"bookshop-approuter:v1",
1111
"--path",
1212
"app",
1313
[

test/expected/buildWithoutType.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
[
88
"pack",
99
"build",
10-
"bookshop-approuter",
10+
"bookshop-approuter:v1",
1111
"--path",
1212
"app",
1313
"--builder",

test/expected/repositoryOption.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
[
88
"pack",
99
"build",
10-
"bookshop-approuter",
10+
"bookshop-approuter:v1",
1111
"--path",
1212
"app",
1313
[
@@ -39,7 +39,7 @@
3939
[
4040
"pack",
4141
"build",
42-
"book-srv",
42+
"book-srv:latest",
4343
"--path",
4444
".",
4545
[

0 commit comments

Comments
 (0)