Useless MethodHandles code in server entrypoint (& other random comments on the code)

[solonovamax]

Why is there some seemingly useless MethodHandles code in the server entrypoint?

none of it seems to do anything, so why is it there?

[solonovamax]

there also seems to be some weird stuff like DirectionBool, which is just empty

[solonovamax]

also in Sampler you are doing some funny reflection stuff to avoid hotspot optimizing away the field assignment (based on the comment)

afaik if you mark the field as volatile, that should prevent it from optimizing it out by essentially saying "other threads may do funny stuff and mess around with this", though I could be wrong on that. you'd have to try it out. I checked with some people who know slightly more about the jvm than I do, and yeah, volatile is what you want (I was like 85% sure but wanted to double check)

[RubixTheSlime]

a lot of the dead weight code is simply there because it's still really early in development so i haven't bothered to clean anything up, unless it affects the profiler's performance. like there's one part where it calculates several types of averages and then does nothing with any of them. with the MethodHandles i was at one point experimenting with some sort of primer part to account for the first of any given thing in a tick taking longer to process (at the time i had only noticed that the first tile tick, entity, tile entity, etc in general was slower, not necessarily of each individual type of entity), and just made a centralized non-optimizable no-op as part of the code before realizing that the issue was more complex than i thought.

thank you for the volatile tip! i normally don't work with threads so i completely forgot about that and just googled "how to make code not optimize out"