From 0e52a005c953c11fd0ab15b995bd514bb85ef550 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dalibor=20Karlovi=C4=87?= Date: Fri, 14 Apr 2023 14:33:54 +0200 Subject: [PATCH] fix: correct collection name for Milvus store to use underscores (#793) * fix: correct collection name for Milvus store Current name produces an error when using Milvus 2.3.0 "Invalid collection name: goldel-escher-bach. collection name can only contain numbers, letters and underscores" * Update milvus.md --- .../modules/indexes/vector_stores/integrations/milvus.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/docs/modules/indexes/vector_stores/integrations/milvus.md b/docs/docs/modules/indexes/vector_stores/integrations/milvus.md index 21de89425c8d..f2521fab782e 100644 --- a/docs/docs/modules/indexes/vector_stores/integrations/milvus.md +++ b/docs/docs/modules/indexes/vector_stores/integrations/milvus.md @@ -49,13 +49,13 @@ const vectorStore = await Milvus.fromTexts( [{ id: 2 }, { id: 1 }, { id: 3 }, { id: 4 }, { id: 5 }], new OpenAIEmbeddings(), { - collectionName: "goldel-escher-bach", + collectionName: "goldel_escher_bach", } ); // or alternatively from docs const vectorStore = await Milvus.fromDocuments(docs, new OpenAIEmbeddings(), { - collectionName: "goldel-escher-bach", + collectionName: "goldel_escher_bach", }); const response = await vectorStore.similaritySearch("scared", 2); @@ -70,7 +70,7 @@ import { OpenAIEmbeddings } from "langchain/embeddings/openai"; const vectorStore = await Milvus.fromExistingCollection( new OpenAIEmbeddings(), { - collectionName: "goldel-escher-bach", + collectionName: "goldel_escher_bach", } );