Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent permission API/WebClient #7144

Closed
jansobczak opened this issue Jun 1, 2017 · 3 comments · Fixed by #7212
Closed

Inconsistent permission API/WebClient #7144

jansobczak opened this issue Jun 1, 2017 · 3 comments · Fixed by #7212
Assignees
Milestone

Comments

@jansobczak
Copy link

Rocket.Chat Version: 0.56.0-rc.6
Running Instances: 1
DB Replicaset OpLog:Disabled
Node Version:v4.5.0

I created a permission role with only one permission called external_user:
view-joined-room: true
In web version of RocketChat user cannot search for any user or public channel which is desired action. But in API this doesn't work at all.
If I authorize as a test.user with those external_user permissions only I'm able to list channels and users using those requests:
/api/v1/users.list
/api/v1/channels.list

Which in my opinion is a bug.

Expected behavior:
If user cannot see channels in web version he or she should not be able to look up them by API.

@graywolf336
Copy link
Contributor

This means the permission check is only client side and not server side. Which means this effects not only the rest api but also the real time api.

@graywolf336
Copy link
Contributor

@Jasobeczek Let me know what you think of #7212, I believe it fixes the incorrect permissions.

@jansobczak
Copy link
Author

Yes, @graywolf336 your fixes are one way of correcting this bug. Thanks!.
The real thing would be team or group features which I know that there are a issues for.

@rodrigok rodrigok added this to the 0.57.3 milestone Jul 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants