Remove Globals #12369
Milestone
Comments
This was referenced Oct 19, 2018
|
woah - what an epic! 👍 for the effort! |
|
@mrsimpson this is just the first and second fases :) we have more to come, the goal is have everything decoupled and rewritten in typescript 😛 |
This was referenced Oct 29, 2018
This was referenced Nov 5, 2018
This was referenced Feb 5, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
First step
Remove all globals from
.eslintrcInternal
__meteor_runtime_config__may not be possible__meteor_bootstrap__may not be possiblemay not be possiblemay not be possibleNpmPackageTAPi18n
JitsiMeetExternalAPI (moved to own eslint file inside the package) #13421
DynamicCss (moved to own eslint file inside the package) #13421
globalslanguage_namesTAPi18nextWorking on
VRecDialog [FIX] Remove unused code for Cordova #13188cordova [FIX] Remove unused code for Cordova #13188device [FIX] Remove unused code for Cordova #13188facebookConnectPlugin [FIX] Remove unused code for Cordova #13188Servers [FIX] Remove unused code for Cordova #13188TwitterConnect [FIX] Remove unused code for Cordova #13188OnePasswordAccountBox Convert rocketchat:ui to main module structure #13132Accounts Removal of EJSON, Accounts, Email, HTTP, Random, ReactiveDict, ReactiveVar, SHA256 and WebApp global variables #12377AgentUsers Convert rocketchat-livechat to main module structure #12942alerts Convert rocketchat:ui to main module structure #13132AudioRecorder Convert rocketchat:ui to main module structure #13132Blaze Removal of Template, Blaze, BlazeLayout, FlowRouter, DDPRateLimiter, Session, UAParser, Promise, Reload and CryptoJS global variables #12433BlazeLayout Removal of Template, Blaze, BlazeLayout, FlowRouter, DDPRateLimiter, Session, UAParser, Promise, Reload and CryptoJS global variables #12433browser Move globals of test to a specific eslintrc file #12959CachedChatSubscription Convert rocketchat:ui to main module structure #13132ChatMessage Convert rocketchat:ui to main module structure #13132chatMessages Convert rocketchat:ui to main module structure #13132ChatMessages Convert rocketchat:ui to main module structure #13132ChatRoom Convert rocketchat:ui to main module structure #13132ChatSubscription Convert rocketchat:ui to main module structure #13132check Removal of Match, check, moment, Tracker and Mongo global variables #12410CryptoJS Removal of Template, Blaze, BlazeLayout, FlowRouter, DDPRateLimiter, Session, UAParser, Promise, Reload and CryptoJS global variables #12433DDPRateLimiter Removal of Template, Blaze, BlazeLayout, FlowRouter, DDPRateLimiter, Session, UAParser, Promise, Reload and CryptoJS global variables #12433Department Convert rocketchat-livechat to main module structure #12942EJSON Removal of EJSON, Accounts, Email, HTTP, Random, ReactiveDict, ReactiveVar, SHA256 and WebApp global variables #12377Email Removal of EJSON, Accounts, Email, HTTP, Random, ReactiveDict, ReactiveVar, SHA256 and WebApp global variables #12377FileUpload Convert rocketchat-file-upload to main module structure #13094fileUpload Convert rocketchat:ui to main module structure #13132fileUploadHandler Convert rocketchat-file-upload to main module structure #13094fireGlobalEvent Convert rocketchat:ui to main module structure #13132FlowRouter Removal of Template, Blaze, BlazeLayout, FlowRouter, DDPRateLimiter, Session, UAParser, Promise, Reload and CryptoJS global variables #12433getAvatarUrlFromUsername Convert rocketchat:ui to main module structure #13132getNextAgent Convert rocketchat-livechat to main module structure #12942handleError Convert rocketchat-action-links to main module structure #12503HTTP Removal of EJSON, Accounts, Email, HTTP, Random, ReactiveDict, ReactiveVar, SHA256 and WebApp global variables #12377isChrome Move isFirefox and isChrome functions to rocketchat-utils #13011isFirefox Move isFirefox and isChrome functions to rocketchat-utils #13011isRtl Move tapi18n t and isRtl functions from ui to utils #13005KonchatNotification Convert rocketchat:ui to main module structure #13132LivechatCustomField Convert rocketchat-livechat to main module structure #12942LivechatDepartment Convert rocketchat-livechat to main module structure #12942LivechatDepartmentAgents Convert rocketchat-livechat to main module structure #12942livechatManagerRoutes Convert rocketchat-livechat to main module structure #12942LivechatMonitoring Convert rocketchat-livechat to main module structure #12942LivechatPageVisited Convert rocketchat-livechat to main module structure #12942LivechatTrigger Convert rocketchat-livechat to main module structure #12942Logger Convert rocketchat-logger to main module structure and remove Logger from eslintrc #12995Match Removal of Match, check, moment, Tracker and Mongo global variables #12410menu Convert rocketchat:ui to main module structure #13132Meteor Removal of Meteor global variable #12371modal Convert rocketchat:ui to main module structure #13132Modernizr Convert rocketchat:ui to main module structure #13132moment Removal of Match, check, moment, Tracker and Mongo global variables #12410Mongo Removal of Match, check, moment, Tracker and Mongo global variables #12410MsgTyping Convert rocketchat:ui to main module structure #13132parentCall Convert rocketchat-livechat to main module structure #12942popout Convert rocketchat:ui to main module structure #13132popover Convert rocketchat:ui to main module structure #13132Promise Removal of Template, Blaze, BlazeLayout, FlowRouter, DDPRateLimiter, Session, UAParser, Promise, Reload and CryptoJS global variables #12433Random Removal of EJSON, Accounts, Email, HTTP, Random, ReactiveDict, ReactiveVar, SHA256 and WebApp global variables #12377ReactiveDict Removal of EJSON, Accounts, Email, HTTP, Random, ReactiveDict, ReactiveVar, SHA256 and WebApp global variables #12377ReactiveVar Removal of EJSON, Accounts, Email, HTTP, Random, ReactiveDict, ReactiveVar, SHA256 and WebApp global variables #12377readMessage Convert rocketchat:ui to main module structure #13132Reload Removal of Template, Blaze, BlazeLayout, FlowRouter, DDPRateLimiter, Session, UAParser, Promise, Reload and CryptoJS global variables #12433RocketChatFile Removed RocketChatFile from globals #12650RoomHistoryManager Convert rocketchat:ui to main module structure #13132RoomManager Convert rocketchat:ui to main module structure #13132RoomRoles Convert rocketchat:ui to main module structure #13132ServiceConfiguration Remove global ServiceConfiguration #12960Session Removal of Template, Blaze, BlazeLayout, FlowRouter, DDPRateLimiter, Session, UAParser, Promise, Reload and CryptoJS global variables #12433SHA256 Removal of EJSON, Accounts, Email, HTTP, Random, ReactiveDict, ReactiveVar, SHA256 and WebApp global variables #12377SideNav Convert rocketchat:ui to main module structure #13132t Move tapi18n t and isRtl functions from ui to utils #13005TAPi18n Removal of TAPi18n and TAPi18next global variables #12467TAPi18next Removal of TAPi18n and TAPi18next global variables #12467Template Removal of Template, Blaze, BlazeLayout, FlowRouter, DDPRateLimiter, Session, UAParser, Promise, Reload and CryptoJS global variables #12433TimeSync Move globals of test to a specific eslintrc file #12959toastr Remove global toastr #12961toolbarSearch Convert rocketchat-ui-sidenav to main module structure #13098Tracker Removal of Match, check, moment, Tracker and Mongo global variables #12410Trigger Convert rocketchat-livechat to main module structure #12942Triggers Convert rocketchat-livechat to main module structure #12942UAParser Removal of Template, Blaze, BlazeLayout, FlowRouter, DDPRateLimiter, Session, UAParser, Promise, Reload and CryptoJS global variables #12433updateAvatarOfUsername Convert rocketchat:ui to main module structure #13132UserRoles Convert rocketchat:ui to main module structure #13132VideoRecorder Convert rocketchat:ui to main module structure #13132visitor Convert rocketchat-livechat to main module structure #12942WebApp Removal of EJSON, Accounts, Email, HTTP, Random, ReactiveDict, ReactiveVar, SHA256 and WebApp global variables #12377Second step
Remove all globals defined in files
/* globalsRemove /* globals */ from files wave-1 #12984Remove /* globals */ wave 2 #12988Remove /* globals */ wave 3 #12997Third step
Convert all packages to use Meteor modular package structure
mainModule.Will stay as a package
Working on
chatpal-search Convert chatpal search package to modular structure #12485meteor-accounts-saml Convert meteor-accounts-saml to main module structure #12486meteor-autocomplete Convert meteor-autocomplete package to main module structure #12491meteor-timesync Convert meteor-timesync to main module structure #12495rocketchat-2fa Convert rocketchat-2fa to main module structure #12501rocketchat-accountsrocketchat-action-links Convert rocketchat-action-links to main module structure #12503rocketchat-analytics Convert rocketchat-2fa to main module structure #12501rocketchat-api Convert rocketchat-api to main module structure #12510rocketchat-assets Convert rocketchat-assets to main module structure #12521rocketchat-authorization Convert rocketchat-authorization to main module structure #12523rocketchat-autolinker Convert rocketchat-autolinker to main module structure #12529rocketchat-autotranslate Convert rocketchat-autotranslate to main module structure #12530rocketchat-bigbluebuttonrocketchat-blockstackrocketchat-bot-helpers Convert rocketchat-bot-helpers to main module structure #12531rocketchat-cas Convert rocketchat-cas to main module structure #12532rocketchat-channel-settings Convert rocketchat-channel-settings to main module structure #12594rocketchat-channel-settings-mail-messages Convert rocketchat-channel-settings-mail-messages to main module structure #12537rocketchat-colors Convert rocketchat-colors to main module structure #12538rocketchat-cors Convert rocketchat-cors to main module structure #12595rocketchat-crowd Convert rocketchat-crowd to main module structure #12596rocketchat-custom-oauth Globals/main module custom oauth #13037rocketchat-custom-sounds Convert rocketchat-custom-sounds to main module structure #12599rocketchat-dolphin Convert rocketchat-dolphin to main module structure #12600rocketchat-drupal Convert rocketchat-drupal to main module structure #12601rocketchat-e2erocketchat-emoji Convert rocketchat-emoji to main module structure #12603rocketchat-emoji-custom Convert rocketchat-emoji-custom to main module structure #12604rocketchat-emoji-emojione Convert emoji-emojione to main module structure #12605rocketchat-error-handler Convert rocketchat-error-handler to main module structure #12606rocketchat-favico Convert rocketchat-favico to main module structure #12607rocketchat-file Convert rocketchat-file to main module structure #12644rocketchat-file-upload Convert rocketchat-file-upload to main module structure #13094rocketchat-github-enterprise Convert rocketchat-github-enterprise to main module structure #12642rocketchat-gitlab Convert rocketchat-gitlab to main module structure #12646rocketchat-google-natural-language Added imports for global variables in rocketchat-google-natural-language package #12647rocketchat-google-vision Convert rocketchat-google-vision to main module structure #12649rocketchat-grant Convert rocketchat-grant to main module structure #12657rocketchat-grant-facebookrocketchat-grant-githubrocketchat-grant-googlerocketchat-graphql Convert rocketchat-graphql to main module structure #12658rocketchat-highlight-words Convert rocketchat-highlight-words to main module structure #12659rocketchat-iframe-login Convert rocketchat-iframe-login to main module structure #12661rocketchat-importer Convert rocketchat-importer to main module structure #12662rocketchat-importer-csv Convert rocketchat-importer-csv to main module structure #12663rocketchat-importer-hipchat Convert rocketchat-importer-hipchat to main module structure #12664rocketchat-importer-hipchat-enterprise Convert rocketchat-importer-hipchat-enterprise to main module structure #12665rocketchat-importer-slack Convert rocketchat-importer-slack to main module structure #12666rocketchat-importer-slack-users Convert rocketchat-importer-slack-users to main module structure #12669rocketchat-integrations Convert rocketchat-integrations to main module structure #12670rocketchat-internal-hubot Convert rocketchat-internal-hubot to main module structure #12671rocketchat-irc Convert rocketchat-irc to main module structure #12672rocketchat-issuelinks Convert rocketchat-issuelinks to main module structure #12674rocketchat-katex Convert rocketchat-katex to main module structure #12895rocketchat-lazy-loadrocketchat-ldap Convert rocketchat-ldap to main module structure #12678rocketchat-livechat Convert rocketchat-livechat to main module structure #12942rocketchat-livestream Convert rocketchat-livestream to main module structure #12679rocketchat-logger Convert rocketchat-logger to main module structure and remove Logger from eslintrc #12995rocketchat-mail-messages Convert rocketchat-mail-messages to main module structure #12682rocketchat-mailer Rocketchat mailer #13036rocketchat-mapview Convert rocketchat-mapview to main module structure #12701rocketchat-markdown Convert rocketchat-markdown to main module structure #12755rocketchat-mentions Convert rocketchat-mentions to main module structure #12756rocketchat-mentions-flextab Convert rocketchat-mentions-flextab to main module structure #12757rocketchat-message-action Convert rocketchat-message-action to main module structure #12759rocketchat-message-attachments Convert rocketchat-message-attachments to main module structure #12760rocketchat-message-mark-as-unread Convert rocketchat-message-mark-as-unread to main module structure #12766rocketchat-message-pin Convert rocketchat-message-pin to main module structure #12767rocketchat-message-snippet Convert rocketchat-message-snippet to main module structure #12768rocketchat-message-star Convert rocketchat-message-star to main module structure #12770rocketchat-migrations Convert rocketchat-migrations to main-module structure #12772rocketchat-nrrrocketchat-oauth2-server-config Convert rocketchat-oauth2-server-config to main module structure #12773rocketchat-oembed Convert rocketchat-oembed to main module structure #12775rocketchat-otr Convert rocketchat-otr to main module structure #12777rocketchat-postcssrocketchat-push-notifications Convert rocketchat-push-notifications to main module structure #12778rocketchat-reactions Convert rocketchat-reactions to main module structure #12888rocketchat-retention-policy Convert rocketchat-retention-policy to main module structure #12797rocketchat-sandstorm Convert rocketchat-sandstorm to main module structure #12799rocketchat-search Convert rocketchat-search to main module structure #12801rocketchat-setup-wizard Convert rocketchat-setup-wizard to main module structure #12806rocketchat-slackbridge Convert rocketchat-slackbridge to main module structure #12807rocketchat-slashcommand-asciiarts Convert rocketchat-slashcommands-asciiarts to main module structure #12808rocketchat-slashcommands-archiveroom Convert rocketchat-slashcomands-archiveroom to main module structure #12810rocketchat-slashcommands-create Convert rocketchat-slashcommands-create to main module structure #12811rocketchat-slashcommands-help Convert rocketchat-slashcommands-help to main module structure #12812rocketchat-slashcommands-hide Convert rocketchat-slashcommands-hide to main module structure #12813rocketchat-slashcommands-invite Convert rocketchat-slashcommands-invite to main module structure #12814rocketchat-slashcommands-inviteall Convert rocketchat-slashcommands-inviteall to main module structure #12815rocketchat-slashcommands-join Convert rocketchat-slashcommands-join to main module structure #12816rocketchat-slashcommands-kick Convert rocketchat-slashcommands-kick to main module structure #12817rocketchat-slashcommands-leave Convert rocketchat-slashcommands-leave to main module structure #12821rocketchat-slashcommands-me Convert rocketchat-slashcommands-me to main module structure #12822rocketchat-slashcommands-msg Convert rocketchat-slashcommands-msg to main module structure #12823rocketchat-slashcommands-mute Convert rocketchat-slashcommands-mute to main module structure #12824rocketchat-slashcommands-open Convert rocketchat-slashcommands-open to main module structure #12825rocketchat-slashcommands-topic Convert rocketchat-slashcommands-topic to main module structure #12826rocketchat-slashcommands-unarchiveroom Convert rocketchat-slashcommands-unarchiveroom to main module structure #12827rocketchat-slider Convert rocketchat-slider to main module structure #12828rocketchat-smarsh-connector Convert rocketchat-smarsh-connector to main module structure #12830rocketchat-sms Convert rocketchat-sms to main module structure #12831rocketchat-spotify Convert rocketchat-spotify to main module structure #12832rocketchat-statistics Convert rocketchat-statistics to main module structure #12833rocketchat-theme Convert rocketchat-theme to main module structure #12896rocketchat-token-login Convert rocketchat-token-login to main module structure #12837rocketchat-tokenpass Convert rocketchat-tokenpass to main module structure #12838rocketchat-tooltip Convert rocketchat-tooltip to main module structure #12839rocketchat-tutum Remove rocketchat-tutum package #12840 (Removed)rocketchat-ui Convert rocketchat:ui to main module structure #13132rocketchat-ui-account Convert rocketchat-ui-account to main module structure #12842rocketchat-ui-admin Convert rocketchat-ui-admin to main module structure #12844rocketchat-ui-clean-history Convert rocketchat-ui-clean-history to main module structure #12846rocketchat-ui-flextab Convert rocketchat-ui-flextab to main module structure #12859rocketchat-ui-login Convert rocketchat-ui-login to main module structure #12861rocketchat-ui-master Convert rocketchat-ui-master to main module structure #13107rocketchat-ui-message Convert rocketchat-ui-message to main module structure #12871rocketchat-ui-sidenav Convert rocketchat-ui-sidenav to main module structure #13098rocketchat-ui-vrecord Convert rocketchat-ui-vrecord to main module structure #12875rocketchat-user-data-download Convert rocketchat-user-data-dowload to main module structure #12877rocketchat-version-check Convert rocketchat-version-check to main module structure #12879rocketchat-versionrocketchat-videobridge Convert rocketchat-videobridge to main module structure #12881rocketchat-webdav Convert rocketchat-webdav to main module structure #12886rocketchat-webrtc Convert rocketchat-webrtc to main module structure #13117rocketchat-wordpress Convert rocketchat-wordpress to main module structure #12887Extra Packages added to be able to unpacking
rocketchat:modelsMove rocketchat models #13027rocketchat:settingsMove rocketchat settings to specific package #13026rocketchat:callbacksMove/create rocketchat callbacks #13034rocketchat:promisesMove rocketchat promises #13039rocketchat:utilsMove isFirefox and isChrome functions to rocketchat-utils #13011rocketchat:ui-utilsMove tapi18n t and isRtl functions from ui to utils #13005rocketchat:metricsMove/create rocketchat metrics #13032rocketchat:notificationsGlobals/move rocketchat notifications #13035rocketchat:ui-cached-collectionConvert rocketchat-ui-master to main module structure #13107The text was updated successfully, but these errors were encountered: