Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove submodules, add full physfs #10

Merged
merged 3 commits into from
Aug 27, 2022
Merged

Conversation

konsumer
Copy link
Contributor

@konsumer konsumer commented Aug 6, 2022

I had issues with miniphysfs building on mac, and noticed that the compiled size is roughly the same, depending on the options you use (for example disabling all but zip.) This PR shows an easy-to-build & simple alternative setup, using regular physfs, that pulls raylib & physfs from git (no submodules, just cmake config.)

I find this kind of structure much more versatile, easier to use/setup, but I think for your lib it probly needs a bit more work to make it nicer for users (I'm not really exposing the lib correctly, just static building the demos.)

WARNING: This is not really a drop-in replacement, as I wasn't quite sure how to structure the project to work well as a dep of user's projects. This is more of an example project that builds all the examples.

@konsumer
Copy link
Contributor Author

konsumer commented Aug 6, 2022

If instructions were simply "put this .h file in your project, and link cmake like this..." it might be simple enough, but you probly know a better way to set it all up. I think in my own project I will probly just drop in the raylib-physfs header, and use my current cmake that pulls raylib & physfs.

@RobLoach RobLoach merged commit e1a79c7 into RobLoach:master Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants