Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin to roave/better-reflection:^5 #348

Closed
Ocramius opened this issue Dec 6, 2021 · 2 comments · Fixed by #368
Closed

Pin to roave/better-reflection:^5 #348

Ocramius opened this issue Dec 6, 2021 · 2 comments · Fixed by #368
Assignees
@Ocramius
Labels
dependencies Pull requests that update a dependency file enhancement php Pull requests that update Php code
Milestone
6.0.0

Comments

@Ocramius
Copy link
Member

Ocramius commented Dec 6, 2021

In #324 ( #324 (comment) ) we use roave/better-reflection:5.0.x-dev@DEV.

This dependency needs to be upgraded after Roave/BetterReflection#904

We can then do a release for 6.0.0
@Ocramius Ocramius added enhancement dependencies Pull requests that update a dependency file php Pull requests that update Php code labels Dec 6, 2021
@Ocramius Ocramius added this to the 6.0.0 milestone Dec 6, 2021
@Ocramius Ocramius self-assigned this Dec 6, 2021
@Ocramius
Copy link
Member Author

Ocramius commented Dec 6, 2021

Note: 6.0.0 really needs a bit of release notes to be provided (on the milestone)

@Ocramius
Copy link
Member Author

Handled in #368

@Ocramius Ocramius linked a pull request Dec 26, 2021 that will close this issue
Upgraded to stable roave/better-reflection:^5.0.0, now that it is released #368
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ocramius Ocramius

Labels
dependencies Pull requests that update a dependency file enhancement php Pull requests that update Php code
Projects
None yet
Milestone
6.0.0
1 participant
@Ocramius