fix(schema): handle float like numbers

RisingStack · Jul 27, 2015 · 5fcc91a · 5fcc91a
1 parent 26e642f
commit 5fcc91a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/schema.js b/src/schema.js
@@ -5,7 +5,7 @@ import {
   GraphQLNonNull,
   GraphQLSchema,
   GraphQLString,
-  GraphQLInt,
+  GraphQLFloat,
   GraphQLBoolean,
   GraphQLList
 } from 'graphql/lib/type';
@@ -70,7 +70,7 @@ function getSchema (models) {
     // Number
     } else if (path.instance === 'Number') {
       return {
-        type: GraphQLInt
+        type: GraphQLFloat
       };
 
     // Date
@@ -118,7 +118,7 @@ function getSchema (models) {
       } else {
         if (path.caster.instance === 'Number') {
           return {
-            type: new GraphQLList(GraphQLInt)
+            type: new GraphQLList(GraphQLFloat)
           };
         } else if (path.caster.instance === 'String') {
           return {

diff --git a/src/schema.spec.js b/src/schema.spec.js
@@ -13,6 +13,7 @@ describe('schema', () => {
         type: String
       },
       age: Number,
+      weight: Number, // to test "floatish" numbers
       createdAt: Date,
       removed: Boolean,
       nums: [Number],
@@ -66,6 +67,7 @@ describe('schema', () => {
       var user = new User({
         name: 'Foo',
         age: 24,
+        weight: 64.7,
         removed: false,
         createdAt: new Date(1437911686190)
       });
@@ -76,6 +78,7 @@ describe('schema', () => {
         user(_id: "${user._id}") {
           name
           age
+          weight
           createdAt
           removed
         }
@@ -86,6 +89,7 @@ describe('schema', () => {
           user: {
             name: 'Foo',
             age: 24,
+            weight: 64.7,
             createdAt: '2015-07-26T11:54:46.190Z',
             removed: false
           }