Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add private service connect resources and datasources #582

Merged
merged 3 commits into from
Feb 5, 2025
Merged

Add private service connect resources and datasources #582

merged 3 commits into from
Feb 5, 2025

Conversation

matpimenta
Copy link
Collaborator

@matpimenta matpimenta commented Jan 27, 2025 •
edited
Loading

This PR adds resources and data sources for provisioning Private Service Connect in GCP on Active-Active and Pro subscriptions.

@matpimenta matpimenta requested a review from pvegh-oc January 27, 2025 14:29
@matpimenta matpimenta force-pushed the private-service-connection branch from 39fe628 to 43d556a Compare January 27, 2025 14:29
@matpimenta
Copy link
Collaborator Author

matpimenta commented Jan 27, 2025 •
edited
Loading

Acceptance tests results (all pass)

Acceptance Test Results 
2025-02-04T15:23:03.0524987Z --- PASS: TestProvider (0.00s)
2025-02-04T15:23:03.0584709Z --- PASS: TestFlexSubModulesAllocationWhenGraphAndQuantityIsOne (0.00s)
2025-02-04T15:23:03.0585802Z --- PASS: TestFlexSubModulesAllocationWhenGraphAndQuantityMoreThanOne (0.00s)
2025-02-04T15:23:03.0586798Z --- PASS: TestFlexSubModulesAllocationWhenOnlyGraphModule (0.00s)
2025-02-04T15:23:03.0588067Z --- PASS: TestFlexSubModulesAllocationWhenNoGraph (0.00s)
2025-02-04T15:23:03.0588911Z --- PASS: TestFlexSubNoModulesInCreatePlanDatabases (0.00s)
2025-02-04T15:23:03.0589831Z --- PASS: TestFlexSubNoAverageItemSizeInBytes (0.00s)
2025-02-04T15:23:03.0590958Z --- PASS: TestFlexSubRediSearchThroughputMeasurementWhenReplicationIsFalse (0.00s)
2025-02-04T15:23:03.0592178Z --- PASS: TestFlexSubRediSearchThroughputMeasurementWhenReplicationIsTrue (0.00s)
2025-02-04T15:23:03.0593392Z --- PASS: TestFlexSubRedisGraphThroughputMeasurementWhenReplicationIsFalse (0.00s)
2025-02-04T15:23:03.0594603Z --- PASS: TestFlexSubRedisGraphThroughputMeasurementWhenReplicationIsTrue (0.00s)
2025-02-04T15:23:03.0610014Z --- PASS: TestIsTime (0.00s)
2025-02-04T15:23:03.0610327Z     --- PASS: TestIsTime/0:00 (0.00s)
2025-02-04T15:23:03.0610657Z     --- PASS: TestIsTime/09:00 (0.00s)
2025-02-04T15:23:03.0610983Z     --- PASS: TestIsTime/12:00 (0.00s)
2025-02-04T15:23:03.0611294Z     --- PASS: TestIsTime/24:00 (0.00s)
2025-02-04T15:23:03.0611623Z     --- PASS: TestIsTime/12:00:00 (0.00s)
2025-02-04T15:23:03.0611953Z     --- PASS: TestIsTime/blah (0.00s)
2025-02-04T15:23:03.0612277Z     --- PASS: TestIsTime/#00 (0.00s)
2025-02-04T15:23:05.7263802Z --- PASS: TestAccDataSourceRedisCloudEssentialsPlan_ambiguous (2.24s)
2025-02-04T15:23:05.7266510Z --- PASS: TestAccDataSourceRedisCloudEssentialsPlan_impossible (2.24s)
2025-02-04T15:23:06.2786279Z --- PASS: TestAccDataSourceRedisCloudCloudAccount_basic (3.22s)
2025-02-04T15:23:06.3191049Z --- PASS: TestAccDataSourceRedisCloudRegions_AWS (3.26s)
2025-02-04T15:23:07.9886000Z --- PASS: TestAccDataSourceRedisCloudRegions_all (2.70s)
2025-02-04T15:23:09.4441044Z --- PASS: TestAccDataSourceRedisCloudPaymentMethod_basic (1.46s)
2025-02-04T15:23:11.0770354Z --- PASS: TestAccDataSourceRedisCloudEssentialsPlan_basic (1.63s)
2025-02-04T15:25:15.3042834Z --- PASS: TestAccResourceRedisCloudEssentialsSubscription_FreeCRUDI (132.25s)
2025-02-04T15:25:16.8584560Z --- PASS: TestAccDataSourceRedisCloudEssentialsPlan_azure (1.55s)
2025-02-04T15:25:18.3249164Z --- PASS: TestAccDataSourceRedisCloudDatabaseModules_basic (1.47s)
2025-02-04T15:25:18.4780766Z --- PASS: TestAccDataSourceRedisCloudEssentialsPlan_subscriptionId (127.40s)
2025-02-04T15:30:08.9050657Z --- PASS: TestAccRedisCloudEssentialsDatabase_BasicCRUDI (290.43s)
2025-02-04T15:39:27.3170401Z --- PASS: TestAccResourceRedisCloudSubscriptionPeering_gcp (984.26s)
2025-02-04T15:44:19.1535732Z --- PASS: TestAccDataSourceRedisCloudProSubscription_ignoresAA (1273.86s)
2025-02-04T15:45:02.8221993Z --- PASS: TestAccResourceRedisCloudActiveActiveDatabase_optionalAttributes (1184.50s)
2025-02-04T15:45:29.2083796Z --- PASS: TestAccDataSourceRedisCloudProDatabase_basic (1342.89s)
2025-02-04T15:45:30.1480764Z --- PASS: TestAccResourceRedisCloudActiveActiveDatabase_timeUtcRequiresValidInterval (0.94s)
2025-02-04T15:45:31.6361460Z --- PASS: TestAccDataSourceRedisCloudDataPersistence_basic (1.49s)
2025-02-04T15:45:53.5216119Z --- PASS: TestAccResourceRedisCloudActiveActiveSubscription_CRUDI (944.62s)
2025-02-04T15:47:10.3943391Z --- PASS: TestAccRedisCloudAclRule_CRUDI (98.76s)
2025-02-04T15:50:05.5483146Z --- PASS: TestAccDataSourceRedisCloudProSubscription_basic (1619.27s)
2025-02-04T16:11:33.2241761Z --- PASS: TestAccResourceRedisCloudActiveActivePrivateServiceConnect_CRUDI (1925.91s)
2025-02-04T16:13:18.1456430Z --- PASS: TestAccResourceRedisCloudActiveActiveDatabase_CRUDI (1644.62s)
2025-02-04T16:13:50.9982630Z --- PASS: TestAccResourceRedisCloudAclUser_CRUDI (1600.60s)
2025-02-04T16:13:51.8383373Z --- PASS: TestAccResourceRedisCloudSubscription_createWithSslCertAndTlsCert (0.84s)
2025-02-04T16:15:39.3992092Z --- PASS: TestAccResourceRedisCloudProDatabase_MultiModules (1533.85s)
2025-02-04T16:20:00.6125920Z --- PASS: TestAccResourceRedisCloudActiveActivePrivateServiceConnectEndpoint_CRUDI (2141.46s)
2025-02-04T16:26:22.7201169Z --- PASS: TestAccResourceRedisCloudActiveActivePrivateServiceConnectEndpointAccepter_Create (2479.90s)
2025-02-04T16:28:53.6689190Z --- PASS: TestAccResourceRedisCloudSubscriptionPeering_aws (1040.44s)
2025-02-04T16:31:36.4972736Z --- PASS: TestAccResourceRedisCloudSubscription_createWithDatabaseWithEnabledTlsAndTlsCert (1098.35s)
2025-02-04T16:32:06.3214217Z --- PASS: TestAccResourceRedisCloudSubscription_createWithoutEnableTlsAndTlsCert (1094.48s)
2025-02-04T16:34:47.4806328Z --- PASS: TestAccResourceRedisCloudSubscription_createWithDatabaseAndDisabledTlsAndInvalidCert (1148.08s)
2025-02-04T16:40:24.4295036Z --- PASS: TestAccResourceRedisCloudSubscription_createWithDatabaseWithEnabledTlsAndInvalidSslCert (1223.82s)
2025-02-04T16:44:36.6324730Z --- PASS: TestAccResourceRedisCloudSubscription_createWithDatabaseWithEnabledTlsAndEmptySslCert (1093.91s)
2025-02-04T16:49:54.4310930Z --- PASS: TestAccResourceRedisCloudProSubscription_preferredAZsModulesOptional (906.95s)
2025-02-04T16:50:28.9370736Z --- PASS: TestAccResourceRedisCloudProSubscription_MaintenanceWindows (1132.44s)
2025-02-04T16:50:29.8554620Z --- PASS: TestAccResourceRedisCloudProDatabase_timeUtcRequiresValidInterval (0.92s)
2025-02-04T16:50:30.0075983Z --- PASS: TestAccResourceRedisCloudSubscription_createWithDatabaseWithEnabledTlsAndSslCert (1296.34s)
2025-02-04T16:57:06.8280759Z --- PASS: TestAccResourceRedisCloudProSubscription_CRUDI (1002.40s)
2025-02-04T17:05:27.6403403Z --- PASS: TestAccResourceRedisCloudProSubscription_RedisVersion (2001.32s)
2025-02-04T17:10:20.9078205Z --- PASS: TestAccResourceRedisCloudTransitGatewayAttachment_Pro (1226.48s)
2025-02-04T17:13:05.4937503Z --- PASS: TestAccResourceRedisCloudProDatabase_respversion (1708.86s)
2025-02-04T17:15:44.8177936Z --- PASS: TestAccResourceRedisCloudProDatabase_optionalAttributes (1514.96s)
2025-02-04T17:15:46.3775417Z --- PASS: TestAccRedisCloudAclRule_DataSourceForDefaultRule (1.56s)
2025-02-04T17:24:12.6295251Z --- PASS: TestAccResourceRedisCloudActiveActiveSubscriptionPeering_gcp (1124.99s)
2025-02-04T17:29:13.0223383Z --- PASS: TestAccResourceRedisCloudActiveActiveSubscriptionPeering_aws (1132.11s)
2025-02-04T17:33:25.4119967Z --- PASS: TestAccResourceRedisCloudProDatabase_CRUDI (2575.40s)
2025-02-04T17:34:44.7918991Z --- PASS: TestAccCreateReadUpdateImportDeleteAclRole_Pro (1299.30s)
2025-02-04T17:35:45.1436388Z --- PASS: TestAccResourceRedisCloudEssentialsSubscription_PaidCRUDI (60.35s)
2025-02-04T17:35:46.7352228Z --- PASS: TestAccDataSourceRedisCloudRegions_GCP (1.59s)
2025-02-04T17:43:28.3678872Z --- PASS: TestAccResourceRedisCloudPrivateServiceConnectEndpointAccepter_Create (1661.99s)
2025-02-04T17:46:26.8852320Z --- PASS: TestAccResourceRedisCloudPrivateServiceConnect_CRUDI (1334.26s)
2025-02-04T17:49:57.0400632Z --- PASS: TestAccDataSourceRedisCloudSubscriptionPeerings_basic (991.63s)
2025-02-04T17:51:27.1034039Z --- PASS: TestAccResourceRedisCloudPrivateServiceConnectEndpoint_CRUDI (1334.08s)
2025-02-04T18:04:52.0446382Z --- PASS: TestAccResourceRedisCloudActiveActiveSubscriptionRegions_CRUDI (4065.22s)

@matpimenta matpimenta marked this pull request as ready for review February 5, 2025 10:33
@matpimenta matpimenta requested review from trentrosenbaum and removed request for pvegh-oc February 5, 2025 10:33
@matpimenta matpimenta merged commit 9fdd8e9 into main Feb 5, 2025
6 checks passed
@matpimenta matpimenta deleted the private-service-connection branch February 5, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trentrosenbaum trentrosenbaum trentrosenbaum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matpimenta @trentrosenbaum