Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Plans Data Source #489

Merged
merged 3 commits into from
May 8, 2024
Merged

Fixed Plans Data Source #489

merged 3 commits into from
May 8, 2024

Conversation

JohnSharpe
Copy link
Contributor

No description provided.

@JohnSharpe JohnSharpe marked this pull request as ready for review May 3, 2024 15:03
JohnSharpe added 3 commits May 7, 2024 09:15
…ee why a failed task response causes the provider to hang (rather than to just abort/fail)
Copy link
Contributor

@greg-oc greg-oc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small suggestion on a description, otherwise looks good to me!

layout: "rediscloud"
page_title: "Redis Cloud: rediscloud_essentials_plan"
description: |-
Essentials Plan data source in the Terraform provider Redis Cloud.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should be:

Suggested change
Essentials Plan data source in the Terraform provider Redis Cloud.
Essentials Plan data source in the Redis Cloud Terraform provider.

@JohnSharpe JohnSharpe merged commit ad70f18 into main May 8, 2024
6 checks passed
@JohnSharpe JohnSharpe deleted the 5-fixed-plans branch May 8, 2024 12:06
JohnSharpe added a commit that referenced this pull request May 8, 2024
* Added fixed_plans with tests, extra logging on database creation to see why a failed task response causes the provider to hang (rather than to just abort/fail)

* Added documentation

* Renamed fixed_plan to essentials_plan
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants