-
Notifications
You must be signed in to change notification settings - Fork 7
Developer Notes
RedDragonWebDesign edited this page Sep 4, 2020
·
27 revisions
If you are interesting in contributing to the code, here are some notes.
- You can turn on Debug Mode in My Account -> Administrator Options -> Website Settings -> Debug Mode. Debug mode on will do PHP
error_reporting(E_ALL)
- Whenever you add or edit a function, please add variable types. Instead of
function setDebugMode($value)
, please dofunction setDebugMode(bool $value): void
. This helps with tooltips and with bug catching.
The code in this project is workable. I was able to patch in the things my client wanted. But there are several areas that need modernization:
- Was designed for PHP 5. Huge number of notices and warnings when running on PHP 7.4
- Does not follow MVC (Model View Controller). MVC is the excellent practice of separating SQL, HTML, and PHP into different files.
- Many skins, but the skins are not mobile friendly.
- Administrators can't be seen because their rankcategory_id = 3, and that rankcategory_id doesn't exist. To make an administrator visible, make a category for them and put them in it.
- rank_id is both rank and permissions.
- color - not used. rankcategory table has the colors.
- hiderank - hides the rank on the ranks page only, members with that rank still show up in other places
- autodisable - not DSL (days since login) related. Rather, it's a different feature. It'll disable you for failure to get promoted within X autodisable days.