You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
UnsubscriptionError still has the name set, but TimeoutError doesn't, and it's not mentioned in the release notes, so I assume this is an unintentional bug (in any case it can be reintroduced in a semver-patch).
Why not use instanceof?instanceof breaks when multiple RxJS versions are in play, or even just the same version had to be installed multiple times because deduping wasn't possible. It asserts the implementation, err.name asserts an interface. All browser errors use it (e.g. AbortError).
The text was updated successfully, but these errors were encountered:
RxJS version: 6.0.0
Code to reproduce:
Expected behavior:
Should emit
false
after 500ms.Actual behavior:
Throws an error
Error: Timeout has occurred
. (worked in RxJS 5)Additional information:
This broke in commit 2f395da#diff-cd4b33df1ab129e23dc2bc5c12d8369b
UnsubscriptionError
still has thename
set, butTimeoutError
doesn't, and it's not mentioned in the release notes, so I assume this is an unintentional bug (in any case it can be reintroduced in a semver-patch).rxjs/src/internal/util/UnsubscriptionError.ts
Lines 5 to 13 in b948e65
rxjs/src/internal/util/TimeoutError.ts
Lines 8 to 13 in b948e65
Why not use
instanceof
?instanceof
breaks when multiple RxJS versions are in play, or even just the same version had to be installed multiple times because deduping wasn't possible. It asserts the implementation,err.name
asserts an interface. All browser errors use it (e.g.AbortError
).The text was updated successfully, but these errors were encountered: