Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6.0 alpha: Merge rxjs and rxjs/create into just rxjs? #3262

Closed
benlesh opened this issue Jan 26, 2018 · 3 comments
Closed

6.0 alpha: Merge rxjs and rxjs/create into just rxjs? #3262

benlesh opened this issue Jan 26, 2018 · 3 comments

Comments

@benlesh
Copy link
Member

benlesh commented Jan 26, 2018

In 6.0, so far we have:

  • rxjs: Classes, schedulers and utilities: (Observable, Subject, pipe, asyncScheduler, etc)
  • rxjs/create: Observable creation functions (of, from, fromEvent)
  • rxjs/operators: Pipeable operators

I think we should probably merge rxjs/create and rxjs, because:

  1. There are no name collisions
  2. We want to export the EMPTY constant, and it's weird to export a constant from rxjs/create, and even weirder to export empty() from one spot and EMPTY from another.
  3. One less import location

Thoughts?

@rgbkrk
Copy link
Contributor

rgbkrk commented Jan 26, 2018

I like this proposal!

@benlesh
Copy link
Member Author

benlesh commented Mar 15, 2018

This is done, it's all just rxjs now.

@benlesh benlesh closed this as completed Mar 15, 2018
@lock
Copy link

lock bot commented Jun 5, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants