Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify deprecation notice in rxjs-es package #2218

Closed
kwonoj opened this issue Dec 25, 2016 · 10 comments
Closed

Specify deprecation notice in rxjs-es package #2218

kwonoj opened this issue Dec 25, 2016 · 10 comments

Comments

@kwonoj
Copy link
Member

kwonoj commented Dec 25, 2016

RxJS version:
b.12

Code to reproduce:
https://www.npmjs.com/package/rxjs-es

Expected behavior:

Actual behavior:

Additional information:
Currently rxjs-es package is stay there with last available (b.12, https://www.npmjs.com/package/rxjs-es) , and there isn't any update further since newly published package won't include any ES2015 packages. NPM no longer allows delete package so anyone search npm packages can find, install unsupported package. While it is not available to remove packages, at least it is possible to specify given package's deprecated and not recommended to use - such as ghooks does recently (https://www.npmjs.com/package/ghooks), by publishing one dummy package with deprecation notice.

Thoughts? /cc @Blesh, @jayphelps .

@jayphelps
Copy link
Member

jayphelps commented Dec 25, 2016

Npm still supports the deprecate command, I believe? It would then warn the user when they install. Ben will have to do it I think.

@kwonoj
Copy link
Member Author

kwonoj commented Dec 25, 2016

If that's supported, that's good 👍

@aluanhaddad
Copy link
Contributor

👍 for npm deprecating this if it is indeed abandoned. I still see recommendations to use rxjs-es with Rollup fairly often. It is confusing.

@alex-kinokon
Copy link

The official documentation still recommends installing rxjs-es. Perhaps time to update the docs?

@jayphelps
Copy link
Member

jayphelps commented Sep 1, 2017

@benlesh ^^^ they just need to be published

@benlesh
Copy link
Member

benlesh commented Sep 1, 2017

@jayphelps I think what's in master would be in a bad state for publishing docs just now because of the extra docs around the new lettable operators. Once we get that fixed, I'll republish the docs.

@jayphelps
Copy link
Member

@benlesh could you checkout the commit before the stuff you don't want, then publish from there?

@benlesh
Copy link
Member

benlesh commented Sep 1, 2017

@jayphelps .. I could... might be a bit of digging.

@benlesh
Copy link
Member

benlesh commented Mar 16, 2018

Closing this. I don't think this is any longer an issue.

@benlesh benlesh closed this as completed Mar 16, 2018
@lock
Copy link

lock bot commented Jun 5, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants