Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UnfactorizedData #356

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Add UnfactorizedData #356

merged 3 commits into from
Sep 30, 2024

Conversation

wouterwln
Copy link
Member

Adds and exports UnfactorizedData. This can be used to override the default factorization of data variables. An example of this can be found in the tests, where we manually specify a factorization over data variables to fix the issue in #355 with the Transition node.

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.89%. Comparing base (9facd12) to head (05f2b1a).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #356      +/-   ##
==========================================
+ Coverage   84.84%   84.89%   +0.04%     
==========================================
  Files          20       20              
  Lines        1511     1516       +5     
==========================================
+ Hits         1282     1287       +5     
  Misses        229      229              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bvdmitri bvdmitri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nice Wouter! I like it!!

  • We need to adjust the original example linked in the issue
  • We need to document the change

what would you think be the best section to document this new functionality (and the new struct)? We have a small section in the inference where we briefly touch upon running inference with missing values, but we also have a bigger section about the factorization constraints. I maybe will put the thing in the factorization constraints doc with a small note about it in the inference with missing values section. WDYT?

Copy link
Member

@bvdmitri bvdmitri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing @wouterwln , thanks! We can merge when CI is finished

@wouterwln wouterwln merged commit c8c97f0 into main Sep 30, 2024
7 checks passed
@wouterwln wouterwln deleted the add_unfactorizeddata branch September 30, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Predictions in the Bike Rental Demand demo are worse than in RxInfer v2 due to factorization constraints
2 participants