Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialization macro bug fix #313

Merged
merged 3 commits into from
Jun 4, 2024
Merged

Conversation

wouterwln
Copy link
Member

There were some bugs in the @initialization macro, especially a missing warning message when you initialize a variable twice. Thanks @Sepideh-Adamiat for spotting!

@wouterwln wouterwln requested a review from bvdmitri June 4, 2024 12:25
Copy link
Member

@bvdmitri bvdmitri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Thanks!

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.62%. Comparing base (736e74b) to head (c9ea043).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #313      +/-   ##
==========================================
+ Coverage   84.51%   84.62%   +0.11%     
==========================================
  Files          18       18              
  Lines        1466     1470       +4     
==========================================
+ Hits         1239     1244       +5     
+ Misses        227      226       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wouterwln wouterwln merged commit 9dd4d41 into main Jun 4, 2024
6 checks passed
@wouterwln wouterwln deleted the initialization_macro_bug_fix branch June 4, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants