Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(YouTube - Hide ads): Hide YouTube featured section #4111

Closed
3 tasks done
ILoveOpenSourceApplications opened this issue Dec 12, 2024 · 11 comments · Fixed by #4113 or #4078
Closed
3 tasks done

feat(YouTube - Hide ads): Hide YouTube featured section #4111

ILoveOpenSourceApplications opened this issue Dec 12, 2024 · 11 comments · Fixed by #4113 or #4078
Labels
Feature request Requesting a new feature that's not implemented yet

Comments

@ILoveOpenSourceApplications
Copy link
Contributor

Feature description

YouTube has this random recommendation that pop ups in home feed at times. Adding brand_video_singleton.eml should probably do it, as the section don't appear very often.

Image

Motivation

It's either some content from YouTube's end or some promotion based content, also from YouTube. So it's better off hidden.

Acknowledgements

  • I have checked all open and closed feature requests and this is not a duplicate
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
@ILoveOpenSourceApplications ILoveOpenSourceApplications added the Feature request Requesting a new feature that's not implemented yet label Dec 12, 2024
@ILoveOpenSourceApplications
Copy link
Contributor Author

Assumption made based on this.

12-13 00:58:19.149 16921 16921 D revanced: LithoFilterPatch: Searching ID: null Path: brand_video_singleton.eml|a2338bd59f2748a2|CellType|brand_promo_base.eml|c30e69acb8a6b839|ContainerType| BufferStrings: brand-promo-base-container-transition❙flexible_button.eml|24e539e5d128fe35❙brand_promo_base_button_transition_key❙button.eml|713fd10bcb423d23❙video_lockup_brand_video_singleton❙video_lockup.eml|9a58ef0afe85e2e4❙header_layout.eml|d7f521d4105fa2d2❙brand_promo.view❙Featured - Hit Pause. Beware of incomplete facts, understand the full information. - Before you believe any information, know a little more about it - Hit Pause. Beware of incomplete facts, understand the full information. ❙ 32 seconds ❙ Go to channel ❙ YouTube India Spotlight - 821K views - 2 months ago ❙ play video❙$67642dc8-0000-2371-a1ac-582429c745e0

@oSumAtrIX
Copy link
Member

Looks about right

@ILoveOpenSourceApplications
Copy link
Contributor Author

I think this can be added simply to the ads filter and perhaps not a dedicated patch?

@LisoUseInAIKyrios
Copy link
Contributor

Sure. What to call it?

Hide brand promotions?

@ILoveOpenSourceApplications
Copy link
Contributor Author

If we are going with a dedicated toggle then Hide featured recommendation maybe? But is that needed? Why not add it to Hide general ads and be done with it?

@LisoUseInAIKyrios
Copy link
Contributor

LisoUseInAIKyrios commented Dec 12, 2024

YT might use this in the future for other purposes. There's not that many settings in the Ads menu and this isn't exactly the same as hiding ads for Temu.

'Hide featured recommendations' might be confused with hiding recommendations for 'real' videos.

Brand promotion is what YT seems to be calling it based on the component names.

Maybe Hide featured promotions?

@oSumAtrIX
Copy link
Member

I think it makes sense to combine all ad toggles into one video and one other ads toggle. You wouldn't need anything in between

@ILoveOpenSourceApplications
Copy link
Contributor Author

Maybe Hide featured promotions?

I'm fine with this.

I think it makes sense to combine all ad toggles into one video and one other ads toggle.

I'm confused? So, two toggles, one hiding video ads and the other hiding general UI ads?

@LisoUseInAIKyrios
Copy link
Contributor

there's already a few non video ads settings. I think most users rarely visit the ads setting page so having granularity or having only a few settings doesn't matter to them.

@LisoUseInAIKyrios
Copy link
Contributor

LisoUseInAIKyrios commented Dec 12, 2024

Add it to general ads for now. If YT decides to use this feature for more than "always follow group think" public service messages then it can be broke out into its own setting.

@cyberboh
Copy link

Likely it its not an ad. From what i see, it just information from YouTube. Maybe information for new comer in YouTube.
For now, i don't see it in my YT app, could be A/B test or region based information.

@LisoUseInAIKyrios LisoUseInAIKyrios linked a pull request Dec 13, 2024 that will close this issue
1 task
@ILoveOpenSourceApplications ILoveOpenSourceApplications changed the title feat(YouTube): Hide YouTube featured section feat(YouTube - Hide ads): Hide YouTube featured section Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature that's not implemented yet
Projects
None yet
4 participants