Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(YouTube - Change header): Original header is shown #3902

Closed
3 tasks done
ghost opened this issue Nov 12, 2024 · 6 comments · Fixed by #3907 or #3909
Closed
3 tasks done

bug(YouTube - Change header): Original header is shown #3902

ghost opened this issue Nov 12, 2024 · 6 comments · Fixed by #3907 or #3909
Labels
Bug report Something isn't working

Comments

@ghost
Copy link

ghost commented Nov 12, 2024

Bug description

Image
Image
Image
I'm patched youtube with "Change header"- "premium header" option. But when it patches it not showing YouTube Premium, shows default YouTube. Please fix this problem.

Error logs

Solution

No response

Additional context

No response

Acknowledgements

  • I have checked all open and closed bug reports and this is not a duplicate.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
@ghost ghost added the Bug report Something isn't working label Nov 12, 2024
@LisoUseInAIKyrios
Copy link
Contributor

The debug logs are needed to fix this.

Google how to setup adb on a computer, then use adb to collect the logs as described here.

@LisoUseInAIKyrios LisoUseInAIKyrios added the Waiting on author Further information is requested label Nov 12, 2024
@LisoUseInAIKyrios LisoUseInAIKyrios changed the title bug: YouTube Premium header not working bug(YouTube - Change header): Original header is shown Nov 12, 2024
@MarcaDian
Copy link
Contributor

MarcaDian commented Nov 12, 2024

Some users write that If choose this custom webp icons, everything works in 19.43

Screenshot_2024-11-12-17-52-32-208-edit_com.mi.android.globalFileexplorer.jpg

Edit: now also yt_ringo2_... in res/drawable
Screenshot_2024-11-12-18-08-53-693-edit_ru.maximoff.apktool.jpg

@oSumAtrIX
Copy link
Member

Then it probably needs the same treatment as the custom branding patch

@cyberboh
Copy link

This log might help

more_drawer.eml|7ba9a521fa269e52*❙Innertube❙yt_ringo2_wordmark_header_light❙Innertube❙yt_ringo2_wordmark_header_dark❙Trending❙yt_outline_fire_black_24❙FEtrending❙

@LisoUseInAIKyrios LisoUseInAIKyrios removed the Waiting on author Further information is requested label Nov 13, 2024
@kazimmt
Copy link
Contributor

kazimmt commented Nov 22, 2024

@LisoUseInAIKyrios on latest dev release -Oheader=premium*header didn't worked for me
Can you confirm it please

@LisoUseInAIKyrios
Copy link
Contributor

It's working for me.

You may need to put the header argument in quotes since the * can be treated as a wildcard expansion:
-Oheader="premium*header"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
5 participants