Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: reset sources doesn't work untill restarting the app #740

Closed
4 tasks done
kazimmt opened this issue Mar 14, 2023 · 3 comments · Fixed by #752
Closed
4 tasks done

bug: reset sources doesn't work untill restarting the app #740

kazimmt opened this issue Mar 14, 2023 · 3 comments · Fixed by #752
Labels
Bug report Something isn't working

Comments

@kazimmt
Copy link
Contributor

kazimmt commented Mar 14, 2023

Type

Error while running the manager

Bug description

If you change sources to any custom sources & Press reset sources button
It doesn't reset sources untill restarting the app

Steps to reproduce

  • go to ReVanced Manager Settings
  • Set any custom sources
  • Tap reset sources button & press yes
  • it just stays untill restarting the app

Android version

13

Manager version

0.0.57

Target package name

N/A

Target package version.

N/A

Installation type

Non-root

Patches selected.

N/A

Device logs (exported using Manager settings).

N/A

Installer logs (exported using Installer menu option) [unneeded if issue is not during patching].

No response

Screenshots or videos

Screenrecorder-2023-03-15-01-58-09-570.mp4

Solution

No response

Additional context

No response

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
  • The issue is related solely to the ReVanced Manager and not related to patching errors or patches
@kazimmt kazimmt added the Bug report Something isn't working label Mar 14, 2023
@Aunali321
Copy link
Contributor

This is by design.

@oSumAtrIX
Copy link
Member

In that case the design should change in favour of UX or a restart dialog should be incorporated

@validcube validcube linked a pull request Apr 2, 2023 that will close this issue
@Aunali321
Copy link
Contributor

Fiex in 9e8c638.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants