-
-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add "(root)" to "mount" install option and "(non-root)" to "install" option #1534
Comments
Just adding (Root) to the mount option should be enough |
@oSumAtrIX, our new dialog that has an explanation for the methods should be enough to close this issue. What do you think? |
I don't remember the dialog, what does it say? |
I just checked it. It doesn't mention root or non-root terms. So, I think we need a separate PR for this. Or should we edit the strings on the existing PR? |
Add option to mout or install(root) patched apk from sdcard. |
This comment was marked as spam.
This comment was marked as spam.
ReVanced Manager will soon be released as a full rewrite. Over time, many feature requests have been made for the current version of ReVanced Manager, but to accelerate the development of the new version of ReVanced Manager, we have to focus on it, which I am closing this issue according to the contribution guidelines:
This feature request has been closed for one or more of the following reasons:
Regardless, anyone who comes across this feature request can PR it to the current version of ReVanced Manager until the new version is ready. Thanks for your feature request! |
Could this be added now? |
Feature description
When clicking install after patching, a dialog opens with "install" and "mount". I am proposing that the text be changed to "install (non-root)" and "mount (root)" or "mount (requires root)".
Motivation
The "mount" / "insfall" install methods are not quite clear, and I only found out that they are the root/nonroot method after I clicked them. It would be helpful if the text inside the selection dialog included the type of installation so that the user knows what it is before selecting one.
Additional context
No response
Acknowledgements
The text was updated successfully, but these errors were encountered: