Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install button appears even when patching aborts #1174

Closed
4 tasks done
KobeW50 opened this issue Aug 28, 2023 · 1 comment · Fixed by #1177
Closed
4 tasks done

Install button appears even when patching aborts #1174

KobeW50 opened this issue Aug 28, 2023 · 1 comment · Fixed by #1177
Labels
Bug report Something isn't working

Comments

@KobeW50
Copy link
Contributor

KobeW50 commented Aug 28, 2023

Type

Error while running the manager

Bug description

The install button appears even if the patchers aborts.

Also, after pressing the install button, it will say "Installing" even though it isn't installing. Also the export button will appear but when you try exporting the apk the manager will crash, but that may be #1173

Steps to reproduce

Patch any app

Use the back arrow while patching to manually abort

Android version

13

Manager version

1.9.4

Target package name

Any. I tested with YT

Target package version.

18.30.37

Installation type

Non-root

Patches selected.

Default, plus some universal patches

(Experimental patches support was enabled so I wasnt limited to the patched supported by 18.30 37)

Device logs (exported using Manager settings).

Dont have but i can get if needed

Installer logs (exported using Installer menu option) [unneeded if the issue is not during patching].

Copying APK
Reading APK
Decoding app manifest
Loading patches
Merging integrations
Deleting existing resource cache directory
Decoding resources
Executing patches
Alternative thumbnails succeeded
Always autorepeat succeeded
Change package name succeeded
Client spoof succeeded
Comments succeeded
Copy video url succeeded
Custom player overlay opacity succeeded
Disable Shorts on startup succeeded
Disable auto captions succeeded
Disable player popup panels succeeded
Disable zoom haptics succeeded
Enable android debugging succeeded
Enable debugging succeeded
Enable tablet layout succeeded
Export all activities succeeded
External downloads succeeded
HDR auto brightness succeeded
Hide Shorts components succeeded
Hide ads succeeded
Hide album cards succeeded
Hide autoplay button succeeded
Hide breaking news shelf succeeded
Hide captions button succeeded
Hide cast button succeeded
Hide crowdfunding box succeeded
Hide email address succeeded
Hide endscreen cards succeeded
Hide filter bar succeeded
Hide floating microphone button succeeded
Hide info cards succeeded
Hide layout components succeeded
Hide load more button succeeded
Hide player buttons succeeded
Hide seekbar succeeded
Hide timestamp succeeded
Hide video action buttons succeeded
Hide watermark succeeded
Minimized playback succeeded
Navigation buttons succeeded
Old video quality menu succeeded
Open links externally succeeded
Override certificate pinning succeeded
Playback speed succeeded
Player flyout menu succeeded
Predictive back gesture succeeded
Premium heading succeeded
Remember video quality succeeded
Remove screen capture restriction succeeded
Remove screenshot restriction succeeded
Return YouTube Dislike succeeded
Seekbar tapping succeeded
SponsorBlock succeeded
Spoof app version succeeded
Spoof wifi connection succeeded
Swipe controls succeeded
Tablet mini player succeeded
Theme succeeded
Vanced MicroG support succeeded
Video ads succeeded
Wide searchbar succeeded
Compiling modified dex files
Canceling patching process
Compiling modified resources
Press back to exit

Screenshots or video

Screen_Recording_20230828_150603_Files.mp4

Solution

Remove the install button if patcher aborts.

Additional context

No response

Acknowledgments

  • I have searched the existing issues; this is new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I properly filled out all of the requested information in this issue.
  • The issue is solely related to ReVanced Manager and not caused by patches.
@KobeW50 KobeW50 added the Bug report Something isn't working label Aug 28, 2023
@Ushie Ushie linked a pull request Aug 28, 2023 that will close this issue
@Ushie
Copy link
Member

Ushie commented Sep 4, 2023

ReVanced Manager v1.9.5 has been released, should be fixed

@Ushie Ushie closed this as completed Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants