Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: minor inconvenience when downloading updates #1047

Closed
4 tasks done
AnonymouseHucker29 opened this issue Jul 23, 2023 · 8 comments
Closed
4 tasks done

feat: minor inconvenience when downloading updates #1047

AnonymouseHucker29 opened this issue Jul 23, 2023 · 8 comments
Labels
Feature request Requesting a new feature that's not implemented yet

Comments

@AnonymouseHucker29
Copy link

Type

Functionality

Issue

The bug only occurs when there's a manager update.

  • Open Revanced Manager
  • Tap on Update
  • After the download is done, the app automatically installs the apk.
    If this is the case, then it defeats the purpose of the dialog box after the installation which prompts the user whether to install the apk or not.

Feature

Remove the auto install function after the download is finished since there is a dialog box that will prompt the user to install the update

Motivation

It's more of an inconvenience

Additional context

No response

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
  • The issue is related solely to the ReVanced Manager
@AnonymouseHucker29 AnonymouseHucker29 added the Feature request Requesting a new feature that's not implemented yet label Jul 23, 2023
@TheAabedKhan
Copy link
Member

Can you share a screen recording of how the installation is happening automatically? Manager updates are never installed silently even if you are rooted.

@AnonymouseHucker29
Copy link
Author

AnonymouseHucker29 commented Jul 25, 2023

Can you share a screen recording of how the installation is happening automatically? Manager updates are never installed silently even if you are rooted.

I'll try when new update comes

@TheAabedKhan
Copy link
Member

I'll try when new update comes

You can download any previous versions of the manager and then record the update issue you are facing.

@ILoveOpenSourceApplications

Is your issue similar to that of #1030?

@ILoveOpenSourceApplications ILoveOpenSourceApplications added the Waiting on author Further information is requested label Jul 30, 2023
@TheAabedKhan
Copy link
Member

Is your issue similar?

No, that issue is about not getting the installation result. This issue is related to not even getting the installation prompt.

@ILoveOpenSourceApplications ILoveOpenSourceApplications removed the Waiting on author Further information is requested label Aug 3, 2023
@TheAabedKhan
Copy link
Member

@AnonymouseHucker29 you are requested to either update or close this issue.

@AnonymouseHucker29
Copy link
Author

Apologies for the late response.

Anyways, you can see in the screen record that after downloading, there's a toast which says installing update and even if I didn't tap on it, something would pop up (package installer) before even reaching the revanced dialog which asks the user to install the update or not.

VID_20230804145729.mp4

@TheAabedKhan
Copy link
Member

That's the default behavior. The Installing update toast appears to inform users that the Android is now going to launch the Package installer to install the downloaded apk, and because you have multiple apps that can handle the package installer intent, you are asked to select the one you want to use. In the video, you chose the built-in Package Installer app, and the sudden dialog that's appearing is the Package Installer window staging your app to install. Staging took less than a second, so the dialog disappeared immediately.

Conclusion: The app is not updated unless you hit install from the Package Installer dialog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature that's not implemented yet
Projects
None yet
Development

No branches or pull requests

3 participants