From 0013772d0eee41849b93fb59299eefa86b2f7c75 Mon Sep 17 00:00:00 2001 From: Doris Amoakohene Date: Wed, 17 Jul 2024 10:24:47 -0700 Subject: [PATCH 01/10] adding an atime test case for gshift as gforce optimized shift #5205 --- .ci/atime/tests.R | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/.ci/atime/tests.R b/.ci/atime/tests.R index fddfb1347b..596f517732 100644 --- a/.ci/atime/tests.R +++ b/.ci/atime/tests.R @@ -119,6 +119,19 @@ test.list <- atime::atime_test_list( data.table:::setDT(L) }, Slow = "c4a2085e35689a108d67dacb2f8261e4964d7e12", # Parent of the first commit in the PR that fixes the issue (https://github.com/Rdatatable/data.table/commit/7cc4da4c1c8e568f655ab5167922dcdb75953801) - Fast = "1872f473b20fdcddc5c1b35d79fe9229cd9a1d15") # Last commit in the PR that fixes the issue (https://github.com/Rdatatable/data.table/pull/5427/commits) + Fast = "1872f473b20fdcddc5c1b35d79fe9229cd9a1d15"), # Last commit in the PR that fixes the issue (https://github.com/Rdatatable/data.table/pull/5427/commits) + + # Issue reported in: https://github.com/Rdatatable/data.table/issues/1534 + # To be fixed in: https://github.com/Rdatatable/data.table/pull/5205 + "DT shift improved in #5205" = atime::atime_test( + N = 10^seq(1, 7), + setup = { + DT = data.table(x = sample(N), y = sample(1e2,N,TRUE)) + }, + expr = { + data.table:::`[.data.table`(DT,, shift(x, 1, type="lag"), y) + }, + Regression = "7f0ce147eef1dd5cd5ff05dffc3c72f472bcde51", # Parent of the first commit (https://github.com/Rdatatable/data.table/commit/58135017a985f3cc2c6f0d091c4effaec4442f56) in the PR (https://github.com/Rdatatable/data.table/pull/5205/commits) that fixes the issue + Fixed = "a6abac319446ae7dde8bc4501fae40eeb5cc228c") # Commit before the last commit in the PR (https://github.com/Rdatatable/data.table/pull/5205/commits) that fixes the regression ) # nolint end: undesirable_operator_linter. From 25e276f09a7fe8465ab38fed133ab854af27d61d Mon Sep 17 00:00:00 2001 From: Doris Amoakohene Date: Mon, 29 Jul 2024 14:13:08 -0700 Subject: [PATCH 02/10] Fixed some tense error in comments --- .ci/atime/tests.R | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.ci/atime/tests.R b/.ci/atime/tests.R index 596f517732..b60467ccd8 100644 --- a/.ci/atime/tests.R +++ b/.ci/atime/tests.R @@ -126,10 +126,10 @@ test.list <- atime::atime_test_list( "DT shift improved in #5205" = atime::atime_test( N = 10^seq(1, 7), setup = { - DT = data.table(x = sample(N), y = sample(1e2,N,TRUE)) + DT = data.table(x = sample(N), y = sample(1e2, N, TRUE)) }, expr = { - data.table:::`[.data.table`(DT,, shift(x, 1, type="lag"), y) + data.table:::`[.data.table`(DT,, shif(x, 1, type="lag"), y) }, Regression = "7f0ce147eef1dd5cd5ff05dffc3c72f472bcde51", # Parent of the first commit (https://github.com/Rdatatable/data.table/commit/58135017a985f3cc2c6f0d091c4effaec4442f56) in the PR (https://github.com/Rdatatable/data.table/pull/5205/commits) that fixes the issue Fixed = "a6abac319446ae7dde8bc4501fae40eeb5cc228c") # Commit before the last commit in the PR (https://github.com/Rdatatable/data.table/pull/5205/commits) that fixes the regression From 93396cabeddb66e513643107fb48c58c78c39f77 Mon Sep 17 00:00:00 2001 From: Doris Amoakohene Date: Tue, 30 Jul 2024 12:08:38 -0700 Subject: [PATCH 03/10] Fixed typo --- .ci/atime/tests.R | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.ci/atime/tests.R b/.ci/atime/tests.R index b60467ccd8..60d5102e1a 100644 --- a/.ci/atime/tests.R +++ b/.ci/atime/tests.R @@ -129,7 +129,7 @@ test.list <- atime::atime_test_list( DT = data.table(x = sample(N), y = sample(1e2, N, TRUE)) }, expr = { - data.table:::`[.data.table`(DT,, shif(x, 1, type="lag"), y) + data.table:::`[.data.table`(DT,, shift(x, 1, type = "lag"), y) }, Regression = "7f0ce147eef1dd5cd5ff05dffc3c72f472bcde51", # Parent of the first commit (https://github.com/Rdatatable/data.table/commit/58135017a985f3cc2c6f0d091c4effaec4442f56) in the PR (https://github.com/Rdatatable/data.table/pull/5205/commits) that fixes the issue Fixed = "a6abac319446ae7dde8bc4501fae40eeb5cc228c") # Commit before the last commit in the PR (https://github.com/Rdatatable/data.table/pull/5205/commits) that fixes the regression From bb10ce8ae62c6556caada88c3d8e7a3f18ce73c5 Mon Sep 17 00:00:00 2001 From: Doris Amoakohene Date: Wed, 31 Jul 2024 12:43:46 -0700 Subject: [PATCH 04/10] remove >> and == from script --- .ci/atime/tests.R | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/.ci/atime/tests.R b/.ci/atime/tests.R index e72dfc9d6e..6144af00cb 100644 --- a/.ci/atime/tests.R +++ b/.ci/atime/tests.R @@ -121,7 +121,6 @@ test.list <- atime::atime_test_list( Slow = "c4a2085e35689a108d67dacb2f8261e4964d7e12", # Parent of the first commit in the PR that fixes the issue (https://github.com/Rdatatable/data.table/commit/7cc4da4c1c8e568f655ab5167922dcdb75953801) Fast = "1872f473b20fdcddc5c1b35d79fe9229cd9a1d15"), # Last commit in the PR that fixes the issue (https://github.com/Rdatatable/data.table/pull/5427/commits) -<<<<<<< HEAD # Issue reported in: https://github.com/Rdatatable/data.table/issues/1534 # To be fixed in: https://github.com/Rdatatable/data.table/pull/5205 "DT shift improved in #5205" = atime::atime_test( @@ -135,7 +134,7 @@ test.list <- atime::atime_test_list( Regression = "7f0ce147eef1dd5cd5ff05dffc3c72f472bcde51", # Parent of the first commit (https://github.com/Rdatatable/data.table/commit/58135017a985f3cc2c6f0d091c4effaec4442f56) in the PR (https://github.com/Rdatatable/data.table/pull/5205/commits) that fixes the issue Fixed = "a6abac319446ae7dde8bc4501fae40eeb5cc228c") # Commit before the last commit in the PR (https://github.com/Rdatatable/data.table/pull/5205/commits) that fixes the regression ) -======= + # Issue reported in: https://github.com/Rdatatable/data.table/issues/4200 # To be fixed in: https://github.com/Rdatatable/data.table/pull/4558 "DT[by] fixed in #4558" = atime::atime_test( @@ -171,6 +170,4 @@ test.list <- atime::atime_test_list( Slow = "3ca83738d70d5597d9e168077f3768e32569c790", # Circa 2024 master parent of close-to-last merge commit (https://github.com/Rdatatable/data.table/commit/353dc7a6b66563b61e44b2fa0d7b73a0f97ca461) in the PR (https://github.com/Rdatatable/data.table/pull/4501/commits) that fixes the issue Slower = "cacdc92df71b777369a217b6c902c687cf35a70d"), # Circa 2020 parent of the first commit (https://github.com/Rdatatable/data.table/commit/74636333d7da965a11dad04c322c752a409db098) in the PR (https://github.com/Rdatatable/data.table/pull/4501/commits) that fixes the issue - NULL) ->>>>>>> master # nolint end: undesirable_operator_linter. From c899b9cfae0ad3192525bb8ccfa2537f9100e20a Mon Sep 17 00:00:00 2001 From: Doris Amoakohene Date: Wed, 31 Jul 2024 13:24:31 -0700 Subject: [PATCH 05/10] added NULL --- .ci/atime/tests.R | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.ci/atime/tests.R b/.ci/atime/tests.R index 6144af00cb..43062c0a63 100644 --- a/.ci/atime/tests.R +++ b/.ci/atime/tests.R @@ -170,4 +170,6 @@ test.list <- atime::atime_test_list( Slow = "3ca83738d70d5597d9e168077f3768e32569c790", # Circa 2024 master parent of close-to-last merge commit (https://github.com/Rdatatable/data.table/commit/353dc7a6b66563b61e44b2fa0d7b73a0f97ca461) in the PR (https://github.com/Rdatatable/data.table/pull/4501/commits) that fixes the issue Slower = "cacdc92df71b777369a217b6c902c687cf35a70d"), # Circa 2020 parent of the first commit (https://github.com/Rdatatable/data.table/commit/74636333d7da965a11dad04c322c752a409db098) in the PR (https://github.com/Rdatatable/data.table/pull/4501/commits) that fixes the issue +NULL) + # nolint end: undesirable_operator_linter. From 1f8dbbbde91553ac00914c7cb8268c985e11dd2d Mon Sep 17 00:00:00 2001 From: Ani Date: Fri, 13 Sep 2024 14:41:42 -0700 Subject: [PATCH 06/10] Towards resolving merge conflicts --- .ci/atime/tests.R | 64 ++++++++++++++++++++++++++--------------------- 1 file changed, 36 insertions(+), 28 deletions(-) diff --git a/.ci/atime/tests.R b/.ci/atime/tests.R index 43062c0a63..86dc2caca6 100644 --- a/.ci/atime/tests.R +++ b/.ci/atime/tests.R @@ -1,5 +1,7 @@ # A list of performance tests. # +# See documentation in https://github.com/Rdatatable/data.table/wiki/Performance-testing for best practices. +# # Each entry in this list corresponds to a performance test and contains a sublist with three mandatory arguments: # - N: A numeric sequence of data sizes to vary. # - setup: An expression evaluated for every data size before measuring time/memory. @@ -76,7 +78,7 @@ test.list <- atime::atime_test_list( # Performance regression discussed in: https://github.com/Rdatatable/data.table/issues/4311 # Fixed in: https://github.com/Rdatatable/data.table/pull/4440 "shallow regression fixed in #4440" = atime::atime_test( - N = 10^seq(3,8), + N = 10^seq(3, 8), setup = { set.seed(1L) dt <- data.table(a = sample.int(N)) @@ -102,9 +104,9 @@ test.list <- atime::atime_test_list( dt_mod <- copy(dt) }, expr = data.table:::`[.data.table`(dt_mod, , N := .N, by = g), - Before = "be2f72e6f5c90622fe72e1c315ca05769a9dc854", # Parent of the regression causing commit (https://github.com/Rdatatable/data.table/commit/e793f53466d99f86e70fc2611b708ae8c601a451) in the PR that introduced the issue (https://github.com/Rdatatable/data.table/pull/4491/commits) - Regression = "e793f53466d99f86e70fc2611b708ae8c601a451", # Commit responsible for regression in the PR that introduced the issue (https://github.com/Rdatatable/data.table/pull/4491/commits) - Fixed = "58409197426ced4714af842650b0cc3b9e2cb842"), # Last commit in the PR that fixed the regression (https://github.com/Rdatatable/data.table/pull/5463/commits) + Before = "be2f72e6f5c90622fe72e1c315ca05769a9dc854", # Parent of the regression causing commit (https://github.com/Rdatatable/data.table/commit/e793f53466d99f86e70fc2611b708ae8c601a451) in the PR (https://github.com/Rdatatable/data.table/pull/4491/commits) that introduced the issue + Regression = "e793f53466d99f86e70fc2611b708ae8c601a451", # Commit responsible for regression in the PR (https://github.com/Rdatatable/data.table/pull/4491/commits) that introduced the issue + Fixed = "58409197426ced4714af842650b0cc3b9e2cb842"), # Last commit in the PR (https://github.com/Rdatatable/data.table/pull/5463/commits) that fixed the regression # Issue reported in: https://github.com/Rdatatable/data.table/issues/5426 # To be fixed in: https://github.com/Rdatatable/data.table/pull/5427 @@ -118,22 +120,8 @@ test.list <- atime::atime_test_list( data.table:::setattr(L, "class", NULL) data.table:::setDT(L) }, - Slow = "c4a2085e35689a108d67dacb2f8261e4964d7e12", # Parent of the first commit in the PR that fixes the issue (https://github.com/Rdatatable/data.table/commit/7cc4da4c1c8e568f655ab5167922dcdb75953801) - Fast = "1872f473b20fdcddc5c1b35d79fe9229cd9a1d15"), # Last commit in the PR that fixes the issue (https://github.com/Rdatatable/data.table/pull/5427/commits) - - # Issue reported in: https://github.com/Rdatatable/data.table/issues/1534 - # To be fixed in: https://github.com/Rdatatable/data.table/pull/5205 - "DT shift improved in #5205" = atime::atime_test( - N = 10^seq(1, 7), - setup = { - DT = data.table(x = sample(N), y = sample(1e2, N, TRUE)) - }, - expr = { - data.table:::`[.data.table`(DT,, shift(x, 1, type = "lag"), y) - }, - Regression = "7f0ce147eef1dd5cd5ff05dffc3c72f472bcde51", # Parent of the first commit (https://github.com/Rdatatable/data.table/commit/58135017a985f3cc2c6f0d091c4effaec4442f56) in the PR (https://github.com/Rdatatable/data.table/pull/5205/commits) that fixes the issue - Fixed = "a6abac319446ae7dde8bc4501fae40eeb5cc228c") # Commit before the last commit in the PR (https://github.com/Rdatatable/data.table/pull/5205/commits) that fixes the regression -) + Slow = "c4a2085e35689a108d67dacb2f8261e4964d7e12", # Parent of the first commit (https://github.com/Rdatatable/data.table/commit/7cc4da4c1c8e568f655ab5167922dcdb75953801) in the PR (https://github.com/Rdatatable/data.table/pull/5427/commits) that fixes the issue + Fast = "af48a805e7a5026a0c2d0a7fd9b587fea5cfa3c4"), # Last commit in the PR (https://github.com/Rdatatable/data.table/pull/5427/commits) that fixes the issue # Issue reported in: https://github.com/Rdatatable/data.table/issues/4200 # To be fixed in: https://github.com/Rdatatable/data.table/pull/4558 @@ -141,14 +129,12 @@ test.list <- atime::atime_test_list( N = 10^seq(1, 20), setup = { d <- data.table( - id3 = sample(c(seq.int(N*0.9), sample( N*0.9, N*0.1, TRUE))), + id = sample(c(seq.int(N * 0.9), sample(N * 0.9, N * 0.1, TRUE))), v1 = sample(5L, N, TRUE), v2 = sample(5L, N, TRUE) ) }, - expr = { - expr=data.table:::`[.data.table`(d, , max(v1) - min(v2), by = id3) - }, + expr = data.table:::`[.data.table`(d, , max(v1) - min(v2), by = id), Before = "7a9eaf62ede487625200981018d8692be8c6f134", # Parent of the first commit (https://github.com/Rdatatable/data.table/commit/515de90a6068911a148e54343a3503043b8bb87c) in the PR (https://github.com/Rdatatable/data.table/pull/4164/commits) that introduced the regression Regression = "c152ced0e5799acee1589910c69c1a2c6586b95d", # Parent of the first commit (https://github.com/Rdatatable/data.table/commit/15f0598b9828d3af2eb8ddc9b38e0356f42afe4f) in the PR (https://github.com/Rdatatable/data.table/pull/4558/commits) that fixes the regression Fixed = "f750448a2efcd258b3aba57136ee6a95ce56b302"), # Second commit of the PR (https://github.com/Rdatatable/data.table/pull/4558/commits) that fixes the regression @@ -163,13 +149,35 @@ test.list <- atime::atime_test_list( setkey(L, V1) }, ## New DT can safely retain key. - expr = { - data.table:::`[.data.table`(L, , .SD) - }, + expr = data.table:::`[.data.table`(L, , .SD), Fast = "353dc7a6b66563b61e44b2fa0d7b73a0f97ca461", # Close-to-last merge commit in the PR (https://github.com/Rdatatable/data.table/pull/4501/commits) that fixes the issue Slow = "3ca83738d70d5597d9e168077f3768e32569c790", # Circa 2024 master parent of close-to-last merge commit (https://github.com/Rdatatable/data.table/commit/353dc7a6b66563b61e44b2fa0d7b73a0f97ca461) in the PR (https://github.com/Rdatatable/data.table/pull/4501/commits) that fixes the issue Slower = "cacdc92df71b777369a217b6c902c687cf35a70d"), # Circa 2020 parent of the first commit (https://github.com/Rdatatable/data.table/commit/74636333d7da965a11dad04c322c752a409db098) in the PR (https://github.com/Rdatatable/data.table/pull/4501/commits) that fixes the issue -NULL) + # Issue reported in: https://github.com/Rdatatable/data.table/issues/6286 + # Fixed in: https://github.com/Rdatatable/data.table/pull/6296 + "DT[by, verbose = TRUE] improved in #6296" = atime::atime_test( + N = 10^seq(1, 9), + setup = { + dt = data.table(a = 1:N) + dt_mod <- copy(dt) + }, + expr = data.table:::`[.data.table`(dt_mod, , 1, by = a, verbose = TRUE), + Slow = "a01f00f7438daf4612280d6886e6929fa8c8f76e", # Parent of the first commit (https://github.com/Rdatatable/data.table/commit/fc0c1e76408c34a8482f16f7421d262c7f1bde32) in the PR (https://github.com/Rdatatable/data.table/pull/6296/commits) that fixes the issue + Fast = "f248bbe6d1204dfc8def62328788eaadcc8e17a1"), # Merge commit of the PR (https://github.com/Rdatatable/data.table/pull/6296) that fixes the issue + + # Issue reported in: https://github.com/Rdatatable/data.table/issues/1534 + # To be fixed in: https://github.com/Rdatatable/data.table/pull/5205 + "DT shift improved in #5205" = atime::atime_test( + N = 10^seq(1, 7), + setup = { + DT = data.table(x = sample(N), y = sample(1e2, N, TRUE)) + }, + expr = { + data.table:::`[.data.table`(DT,, shift(x, 1, type = "lag"), y) + }, + Regression = "7f0ce147eef1dd5cd5ff05dffc3c72f472bcde51", # Parent of the first commit (https://github.com/Rdatatable/data.table/commit/58135017a985f3cc2c6f0d091c4effaec4442f56) in the PR (https://github.com/Rdatatable/data.table/pull/5205/commits) that fixes the issue + Fixed = "a6abac319446ae7dde8bc4501fae40eeb5cc228c"), # Commit before the last commit in the PR (https://github.com/Rdatatable/data.table/pull/5205/commits) that fixes the regression + NULL) # nolint end: undesirable_operator_linter. From 1ed4d1a90efc098d0eaef974b681f7e5dbe67a2b Mon Sep 17 00:00:00 2001 From: Ani Date: Fri, 13 Sep 2024 14:44:04 -0700 Subject: [PATCH 07/10] Formatting --- .ci/atime/tests.R | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.ci/atime/tests.R b/.ci/atime/tests.R index 86dc2caca6..0873a1a1ef 100644 --- a/.ci/atime/tests.R +++ b/.ci/atime/tests.R @@ -173,9 +173,7 @@ test.list <- atime::atime_test_list( setup = { DT = data.table(x = sample(N), y = sample(1e2, N, TRUE)) }, - expr = { - data.table:::`[.data.table`(DT,, shift(x, 1, type = "lag"), y) - }, + expr = data.table:::`[.data.table`(DT, , shift(x, 1, type = "lag"), y), Regression = "7f0ce147eef1dd5cd5ff05dffc3c72f472bcde51", # Parent of the first commit (https://github.com/Rdatatable/data.table/commit/58135017a985f3cc2c6f0d091c4effaec4442f56) in the PR (https://github.com/Rdatatable/data.table/pull/5205/commits) that fixes the issue Fixed = "a6abac319446ae7dde8bc4501fae40eeb5cc228c"), # Commit before the last commit in the PR (https://github.com/Rdatatable/data.table/pull/5205/commits) that fixes the regression From f394d91cda393fca4679027fff85d761cd8a55ab Mon Sep 17 00:00:00 2001 From: Ani Date: Fri, 13 Sep 2024 14:47:38 -0700 Subject: [PATCH 08/10] Correct comment based on fix status --- .ci/atime/tests.R | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.ci/atime/tests.R b/.ci/atime/tests.R index 0873a1a1ef..a9a3cc4f2b 100644 --- a/.ci/atime/tests.R +++ b/.ci/atime/tests.R @@ -167,7 +167,7 @@ test.list <- atime::atime_test_list( Fast = "f248bbe6d1204dfc8def62328788eaadcc8e17a1"), # Merge commit of the PR (https://github.com/Rdatatable/data.table/pull/6296) that fixes the issue # Issue reported in: https://github.com/Rdatatable/data.table/issues/1534 - # To be fixed in: https://github.com/Rdatatable/data.table/pull/5205 + # Fixed in: https://github.com/Rdatatable/data.table/pull/5205 "DT shift improved in #5205" = atime::atime_test( N = 10^seq(1, 7), setup = { From 3224e7ab4332567134af8b7433ab461f204f5d5f Mon Sep 17 00:00:00 2001 From: Ani Date: Fri, 13 Sep 2024 15:04:56 -0700 Subject: [PATCH 09/10] Try the last one in PR's range of commits (else simplify comment to use 'Second-last'/'Penultimate' if this doesn't work for some reason?) --- .ci/atime/tests.R | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.ci/atime/tests.R b/.ci/atime/tests.R index a9a3cc4f2b..80c4dbbb49 100644 --- a/.ci/atime/tests.R +++ b/.ci/atime/tests.R @@ -175,7 +175,7 @@ test.list <- atime::atime_test_list( }, expr = data.table:::`[.data.table`(DT, , shift(x, 1, type = "lag"), y), Regression = "7f0ce147eef1dd5cd5ff05dffc3c72f472bcde51", # Parent of the first commit (https://github.com/Rdatatable/data.table/commit/58135017a985f3cc2c6f0d091c4effaec4442f56) in the PR (https://github.com/Rdatatable/data.table/pull/5205/commits) that fixes the issue - Fixed = "a6abac319446ae7dde8bc4501fae40eeb5cc228c"), # Commit before the last commit in the PR (https://github.com/Rdatatable/data.table/pull/5205/commits) that fixes the regression + Fixed = "5eec8f2d00521edb0a4a088ad154d065daa869c6"), # Last commit in the PR (https://github.com/Rdatatable/data.table/pull/5205/commits) that fixes the regression NULL) # nolint end: undesirable_operator_linter. From 7a25d4fc65f01647e4ce63682b243948bc67a237 Mon Sep 17 00:00:00 2001 From: Ani Date: Mon, 16 Sep 2024 11:55:59 -0700 Subject: [PATCH 10/10] Slow/Fast (Improvement case) over Regression/Fixed --- .ci/atime/tests.R | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.ci/atime/tests.R b/.ci/atime/tests.R index 80c4dbbb49..2c8731c610 100644 --- a/.ci/atime/tests.R +++ b/.ci/atime/tests.R @@ -174,8 +174,8 @@ test.list <- atime::atime_test_list( DT = data.table(x = sample(N), y = sample(1e2, N, TRUE)) }, expr = data.table:::`[.data.table`(DT, , shift(x, 1, type = "lag"), y), - Regression = "7f0ce147eef1dd5cd5ff05dffc3c72f472bcde51", # Parent of the first commit (https://github.com/Rdatatable/data.table/commit/58135017a985f3cc2c6f0d091c4effaec4442f56) in the PR (https://github.com/Rdatatable/data.table/pull/5205/commits) that fixes the issue - Fixed = "5eec8f2d00521edb0a4a088ad154d065daa869c6"), # Last commit in the PR (https://github.com/Rdatatable/data.table/pull/5205/commits) that fixes the regression + Slow = "7f0ce147eef1dd5cd5ff05dffc3c72f472bcde51", # Parent of the first commit (https://github.com/Rdatatable/data.table/commit/58135017a985f3cc2c6f0d091c4effaec4442f56) in the PR (https://github.com/Rdatatable/data.table/pull/5205/commits) that fixes the issue + Fast = "5eec8f2d00521edb0a4a088ad154d065daa869c6"), # Last commit in the PR (https://github.com/Rdatatable/data.table/pull/5205/commits) that fixes the issue NULL) # nolint end: undesirable_operator_linter.