-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve := error for case when cedta() dispatches [.data.frame #5721
Comments
What is the current error, and what do you suggest we change it to? |
The normal error for when Line 2778 in e6076b0
Not sure yet, but the current message is misleading in this case (emphasis on "ensure |
Is this error message good enough to fix this issue ? "It seems that |
But this error might not come up in a package, or it might be caused by an issue in another package entirely. I am thinking the best way to address this may be in Lines 146 to 155 in 3eefbca
Quickly scan OTOH, maybe using |
Isn't / wasn't |
Yes, it's used within their |
yes that's still surely used where needed. my suggestion is to look for := as root of j though, in same fashion as later in [.data.table, instead of recursive search which might find tidyverse false positives. |
The current error is not very helpful for a package author that forgot to
@import
data.table leading [.data.frame to dispatch as cedta() gives FALSE. So := is used correctly, but still get the error.Difficult (not impossible) to encounter once the package reaches CRAN caliber, more likely for package under early development.
Alternatively, using := is a pretty good sign the author intended [.data.table, so we could consider changing the cedta() result, but I think that will be non-trivial.
The text was updated successfully, but these errors were encountered: