Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export masks for all NSE-only constructs (currently at least '.', 'J', 'patterns') #5604

Closed
MichaelChirico opened this issue Feb 28, 2023 · 2 comments · Fixed by #6125
Closed

Comments

@MichaelChirico
Copy link
Member

MichaelChirico commented Feb 28, 2023

This subsumes #5277.

We export masks for .N, .I, .GRP, .GRPI, .SD, and := to facilitate downstreams doing @importFrom data.table .N to hide R CMD check notes about undefined variables.

We should do the same for all the NSE constructs we interpret inside [ / melt(). Currently, there's no export for ., J, and patterns, all of which could be masked as function(...) NULL.

@AngelFelizR
Copy link
Contributor

Adding measure() to the list as indicated by @tdhock in #5277

@tdhock
Copy link
Member

tdhock commented Feb 1, 2024

wow that is a great idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants