Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revdep FIESTA new failures to re-build vignettes #5540

Closed
tdhock opened this issue Nov 27, 2022 · 0 comments
Closed

revdep FIESTA new failures to re-build vignettes #5540

tdhock opened this issue Nov 27, 2022 · 0 comments
Labels
revdep Reverse dependencies

Comments

@tdhock
Copy link
Member

tdhock commented Nov 27, 2022

revdep FIESTA uses data.table in vignettes, which fail to rebuild when data.table github master is installed.

Quitting from lines 220-224 (FIESTA_tutorial_SA.Rmd) 
Error: processing vignette 'FIESTA_tutorial_SA.Rmd' failed with diagnostics:
Incompatible join types: x.CONDID (integer) and i.DOMAIN (character)

and

Quitting from lines 218-224 (FIESTA_tutorial_MA.Rmd) 
Error: processing vignette 'FIESTA_tutorial_MA.Rmd' failed with diagnostics:
Column or expression 1 of 'by' or 'keyby' is type 'NULL' which is not currently supported. 
If you have a compelling use case, please add it to https://github.com/Rdatatable/data.table/issues/1597. 
As a workaround, consider converting the column to a supported type, 
e.g. by=sapply(list_col, toString), whilst taking care to maintain distinctness in the process.

git bisect says this error started happening after merging #5084
Several other revdeps broke after merging that same PR, and there is a proposed follow-up #5133
Not sure if it fixes this issue though.

@tdhock tdhock added the revdep Reverse dependencies label Nov 27, 2022
@tdhock tdhock closed this as completed Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
revdep Reverse dependencies
Projects
None yet
Development

No branches or pull requests

1 participant