You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Somewhat related to #4060 in appearance but crashes on all versions of R. Different mechanism, similar appearance. Found this while working on amending #4272. I'll submit a fix soon (hopefully). Should I put it in with #4272 or submit a separate PR? These are all related in that they are triggered by passing zero length icols/xcols to Cbmerge.
I'm not a hundred percent on what this should do, but I'd suggest to have it behave the same way for all values of roll.
DT= data.table(A="a", key="A")
DT[data.table(), roll='nearest'] # Will segfault# Proposed return Value == DT[0]:# Empty data.table (0 rows and 1 cols): A
The text was updated successfully, but these errors were encountered:
It should raise error that there is no column to join to. In same PR should be fine.
tlapak
changed the title
Keyed join with empty data.table and roll='nearest' still segfaults
Keyed join with empty data.table and roll='nearest' segfaults
May 28, 2020
Somewhat related to #4060 in appearance but crashes on all versions of R. Different mechanism, similar appearance. Found this while working on amending #4272. I'll submit a fix soon (hopefully). Should I put it in with #4272 or submit a separate PR? These are all related in that they are triggered by passing zero length
icols/xcols
toCbmerge
.I'm not a hundred percent on what this should do, but I'd suggest to have it behave the same way for all values of
roll
.The text was updated successfully, but these errors were encountered: