L2 l3 rebase #5402
Merged
L2 l3 rebase #5402
+169
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 10, 2020
Closed
akelad
suggested changes
Mar 11, 2020
Co-Authored-By: Akela Drissner-Schmid <32450038+akelad@users.noreply.github.com>
Co-Authored-By: Akela Drissner-Schmid <32450038+akelad@users.noreply.github.com>
Co-Authored-By: Akela Drissner-Schmid <32450038+akelad@users.noreply.github.com>
Co-Authored-By: Akela Drissner-Schmid <32450038+akelad@users.noreply.github.com>
|
I think a few things must have gotten lost - urg. Will readdress |
akelad
reviewed
Mar 11, 2020
akelad
reviewed
Mar 11, 2020
|
sorry didn't mean to rerequest right away! |
Co-Authored-By: Akela Drissner-Schmid <32450038+akelad@users.noreply.github.com>
Co-Authored-By: Akela Drissner-Schmid <32450038+akelad@users.noreply.github.com>
akelad
reviewed
Mar 12, 2020
| - add stories with FAQ interruptions in the middle of filling a form | ||
| - add stories with contextual question interruptions (``explain``) in the middle of filling a form | ||
| - specify the value of ``requested_slot`` before the interruption | ||
| - the response to the interruption should match the value of ``requested_slot`` |
There was a problem hiding this comment.
this checklist seems really long and complex... is there any way we could make it a bit more concise?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Status (please check what you already did):
black(please check Readme for instructions)