Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kingdom Hearts II Final Mix Roxas Slowdown #7338

Closed
Jay2008p opened this issue Jan 29, 2020 · 49 comments
Closed

Kingdom Hearts II Final Mix Roxas Slowdown #7338

Jay2008p opened this issue Jan 29, 2020 · 49 comments

Comments

@Jay2008p
Copy link

Jay2008p commented Jan 29, 2020

It seems somewhere in between the build 0.0.5-7091 and now 0.0.8-9454 Roxas has begun to slowdown extremely on anything past that. I'm testing this on 0.0.8-9454. 0.0.6-8272 has the slowdown present but it's not as bad, it makes combat sluggish. After some trial and error 0.0.7-9188 seems to be the worst build with flickering textures and the Roxas slowdown anything before that for me crashes after the cinematic and so does anything after. Log below is from the 0.0.7 build.

System specs are:
i5-6400
GTX 970
8gb ram
Windows 10
RPCS3.log.gz

@Asinin3
Copy link
Contributor

Asinin3 commented Jan 29, 2020

What do you mean by

in between the commit 4876 and now

What is the build number? 4876 would be around the middle of 2017, so you must mean something else. But really, before posting an issue you should go through https://rpcs3.net/compatibility?b and try builds in-between the date it regressed until you find it. Don't test every build, just try and quickly narrow it down first. Developers can't be expected to narrow down regressions like this for you when it may not appear on their system, and it's the responsibility of the person who reports the issue to provide a detailed break-down.

You're also missing a log file.

@Jay2008p
Copy link
Author

Added log and changed the build numbers I used the number on the left side previously instead of saying the builds directly.

@Asinin3
Copy link
Contributor

Asinin3 commented Jan 29, 2020

Is the bug the same as this old issue? #4876 (comment) The game used to run slow whenever roxas was in his attack stance/animation. But it was fixed.

@darkash
Copy link

darkash commented Jan 29, 2020

last known good build
0.0.5-7772
when in stance or atking
image
RPCS3.log.gz

slowdown on 0.0.6-7773 (#5587)
when in stance or atking
image
when idle
image
RPCS3.log.gz

@darkash
Copy link

darkash commented Jan 29, 2020

on 9xxx build, the dips is even more grave that my fps drops to single digit when using 300% scaling, probably thanks to the anti-alias that it's more noticeable.

@Jay2008p
Copy link
Author

Jay2008p commented Jan 29, 2020

Yes it's the same as the old issue but like darkash mentioned it is significantly worse when attacking or in the attack stance.

Edit:
Forgot to mention that the frame rate would drop in the build that was "fixed" whenever roxas would blink and I couldn't get past the opening cinematic without the game freezing.

@Asinin3
Copy link
Contributor

Asinin3 commented Jan 30, 2020

slowdown on 0.0.6-7773 (#5587)

So that's the right pr and build number, but.. how the hell does that pull request to change where game configs are located break this 🤔

Yes it's the same as the old issue but like darkash mentioned it is significantly worse when attacking or in the attack stance.

But that's quite literally what the old issue was.

@darkash
Copy link

darkash commented Jan 31, 2020

slowdown on 0.0.6-7773 (#5587)

So that's the right pr and build number, but.. how the hell does that pull request to change where game configs are located break this 🤔

Yes it's the same as the old issue but like darkash mentioned it is significantly worse when attacking or in the attack stance.

But that's quite literally what the old issue was.

not sure how it is related either, from the commit diff, it only adds 1 parameter to the function and the 1 more if branching
pretty sure it's for loading config before loading the game too

is capture needed for this as well?

@Puremin0rez
Copy link

Puremin0rez commented Feb 19, 2020

I'm experiencing the same issue. Whenever attacking with Roxas, the game will slow down to a very low frame rate and immediately pick back up again afterwards. Game runs at full speed in every other situation.

Willing to help however I can - I am new to RPCS3.

Windows 10, 32GB RAM, i7-4790K, GTX 1080 TI (11GB VRAM)
RPCS3 v0.0.8-9623

@D-TurboKiller
Copy link

D-TurboKiller commented Jun 3, 2020

Can confirm, this issue persists as of the current build (0.0.10-10451). However, it's not exclusively when attacking; it also happens if Roxas blinks his eyes, for example. Possibly related to facial animations? Didn't really notice it during cutscenes if that's the case, could just be during gameplay. And I just recently finished KH1 FM from the 1.5 ReMix release without any major issues.

Also, a moderator previously mentioned that 0.0.5-7096 didn't have such an issue, however I'm going to have to disagree there; besides the fact that this buggy build barely maintains 30 fps on Vulkan with default settings, the framerate cuts in literal half (14-15 fps) whenever attacking. On current builds, I have a stable 30 fps but it dips to 10 fps when attacking.

EDIT: To reiterate, build 0.0.5-7096 was when kd-11 implemented asynchronous decompiling of shaders, which would of course improve performance; It wouldn't be surprising if someone with a beefy machine noticed the vast increase in framerate and assume the issue was fixed, when in fact I suspect the problem itself was never touched upon.

Specs:
OS: W10 64-bits
CPU: AMD A10-7850k (4 cores)
GPU: AMD RX470 (4 GB)
RAM: 8 GB

@mumia7575
Copy link

Having exactly the same drop of frames when roxas attack or blinks his eyes. Any workaround? Like an older build that can run the game without stuttering. Finished today KH1 from KH1.5 Remix and was flawless (except not loading the Chain of Memories, but thats another problem).

@jezuzo
Copy link

jezuzo commented Jun 23, 2020

Having the same problem. Any solution yet?

@pyr0ball
Copy link

pyr0ball commented Sep 4, 2020

Been a few months since this issue was last updated. Just wanted to mention that the same issue is still present on the current build as of today (0.0.12-10820). I'm working on getting through the intro to see if the issue is persistent with both Sora and Roxas (as that wasn't specifically mentioned in this issue). At all other times this game runs smooth as butter.

I'm running on:
i7-9750H
RTX-2060 (Laptop)
32gb DDR4 3200

@Asinin3
Copy link
Contributor

Asinin3 commented Sep 18, 2020

Also, a moderator previously mentioned that 0.0.5-7096 didn't have such an issue, however I'm going to have to disagree there; besides the fact that this buggy build barely maintains 30 fps on Vulkan with default settings, the framerate cuts in literal half (14-15 fps) whenever attacking. On current builds, I have a stable 30 fps but it dips to 10 fps when attacking.

I tested it back then and confirmed it though, see: #4876 (comment)
I'm very confused on where this broke again now. But someone needs to investigate it properly.

EDIT: To reiterate, build 0.0.5-7096 was when kd-11 implemented asynchronous decompiling of shaders, which would of course improve performance; It wouldn't be surprising if someone with a beefy machine noticed the vast increase in framerate and assume the issue was fixed, when in fact I suspect the problem itself was never touched upon.

You really think that the async build made fps go from 3 to 30? It was indeed what fixed it for me. I actually tested around 30 builds at the time to identify it. And it was actually another user who discovered that it as fixed, I just went through to investigate what pull request fixed it so we could close the issue off, and mention it in our progress report. If anything maybe you forgot to clean shader cache when testing between builds which caused the problem to persist on the old build.

image
There's a ton of posts on discord if you're in our server can search for them on that date.

@D-TurboKiller
Copy link

D-TurboKiller commented Sep 18, 2020

If anything maybe you forgot to clean shader cache when testing between builds which caused the problem to persist on the old build.

Nope, I actually read the instructions. I made doubly sure by deleting the entire cache so there wouldn't be any inconsistencies. The cache was rebuilt from scratch in both the old and new versions.
As I've mentioned previously, I think the issue isn't exclusively related to his attacking animation. Perhaps it's a combination between his facial animations (most notably the eyes blinking, causing massive frame drops) and his attack effects (the swooshing color effect, perhaps?). Personally from my experience, fixing such things usually benefits by ending up solving other, seemingly unrelated bugs in the process.

Degrading the bug reporter for his assumed incompetence instead of looking at the issue doesn't solve the problem, but... eh, I get it. Last I checked, the server's help channel was flooded with reports of things already fixed or circumvented, by people looking to play a pirated version on their crappy computer. That's to be expected for emulation in general.
The moderators were clearly uninterested on most of it, for good reason. I posted as much detail as possible there, but it quickly got buried. I'm like to figure things out myself unless it's absolutely uncircumventable, which leads me to either find an alternative myself, or just wait for it to get patched up.
That being said, if it was indeed fixed before, then it's unfortunate, but reoccurring bugs are an inevitable part of programming.
Not a personal attack or anything, just annoyed that there isn't a better way to go about the bug-fixing process... but it is what it is.

As for KH2FM, I ended up replaying it on an english-patched PS2 version of Final Mix, which apart from the low-res videos and some textures, was just as playable as the PS3 version of KH1FM. I don't feel like retrying yet again (far too busy IRL at any rate), so I'll leave it to someone else to test the PS3 version if it ever gets fixed.

@Asinin3
Copy link
Contributor

Asinin3 commented Sep 18, 2020

Degrading the bug reporter for his assumed incompetence instead of looking at the issue doesn't solve the problem, but... eh, I get it.

I get being upset, but how's that any different than you saying that I incorrectly presumed it was fixed because of a performance improvement? It went from 3FPS to 30, and was also fixed for another user. Something else is at play here. I confirmed another user in our discord an hour ago that it's not caused by 0.0.6-7773 as well. However the user above could reproduce it happening on 7773, which makes no sense due to what the pull-request entails.

I really think something strange is going on, needs investigation.

@pyr0ball
Copy link

I've got a decent amount of debugging experience and I'm no stranger to coding, but I lack experience in graphics and emulation software specifically, however I'd be happy to put in some time trying to reproduce issues and provide bugreports if it would help @Asinin3

If you let me know what kind of testing is needed to narrow this down, I can get started

@kd-11
Copy link
Contributor

kd-11 commented Sep 18, 2020

The most important thing here is to find a way to consistently trigger the issue for everyone. A big problem with performance issues (and other issues such as heap corruption, etc) is that unless you can observe it happening in front of you it becomes near impossible to fix, which is the scenario here. The underlying cause could be a combination of hardware configuration, emulator configuration, OS version, 3rd party software, etc.

@pyr0ball
Copy link

@kd-11 well you're in luck because my setup consistently reproduces the issue right now and I can provide a lot of that info

@Asinin3
Copy link
Contributor

Asinin3 commented Sep 18, 2020

@pyr0ball The problem is if other users can reproduce it as well, not just you. For me back then I could reproduce it every run. For the other user in this thread he could reproduce it not working on 7773, but working on 7772. Basically it needs to be confirmed where the cause is across multiple people's systems.

Try using old builds: https://rpcs3.net/compatibility?b - go back months at a time, and narrow down where it broke. Maybe start at the middle of 2019 and use the old build with rpcs3 after clearing cache's (right-click the game and remove them). Then see if it's broken. If it's working then you need to use a newer build, if it is broken then you need to use an older one. Basically just narrow it down quickly by jumping through multiple months of builds at a time, should be able to nail it down faiirly easily since it's easy to reproduce, just make sure to jump like ~4 months at a time when you first start trying to narrow it down.

@darkash
Copy link

darkash commented Sep 18, 2020

@pyr0ball The problem is if other users can reproduce it as well, not just you. For me back then I could reproduce it every run. For the other user in this thread he could reproduce it not working on 7773, but working on 7772. Basically it needs to be confirmed where the cause is across multiple people's systems.

Try using old builds: https://rpcs3.net/compatibility?b - go back months at a time, and narrow down where it broke. Maybe start at the middle of 2019 and use the old build with rpcs3 after clearing cache's (right-click the game and remove them). Then see if it's broken. If it's working then you need to use a newer build, if it is broken then you need to use an older one. Basically just narrow it down quickly by jumping through multiple months of builds at a time, should be able to nail it down faiirly easily since it's easy to reproduce, just make sure to jump like ~4 months at a time when you first start trying to narrow it down.

since you bring this up again, I decided to test it once again, you can ignore my previous report since it indeed was a mistake
perhaps thermal throttle kicks in since I spent like 4 or 5 hours testing random build at the time

at least can now bisect starting from 7773 instead

@ghost
Copy link

ghost commented Sep 23, 2020

Is this about the stutter issue that happens all the time ?
I also get it but I use a laptop .
It runs everything else on 1.5 and 2.5 well its only KH2 that gives me that issue.

@Skooz
Copy link

Skooz commented Sep 25, 2020

Did some testing, using Vulkan and the help of a 60fps tweak, and I've narrowed down a "culprit" build. I put emphasis on that because, even though I've found an obvious performance regression between these builds, this issue is still present and results in a slowdown on both builds. It just becomes a lot more intense and noticeable between these particular builds.

Build 0.0.7-8952 (rpcs3-v0.0.7-8952-c16319f9_win64) seems to be the last "working" build, with fps dropping to around 45 at the lowest while attacking. Since the game is typically locked to 30fps, I doubt most people will ever notice the issue is present.

Build 0.0.7-8956 (rpcs3-v0.0.7-8956-3c440656_win64) the slowdown becomes much more intense, with fps dropping to around 20 while attacking. For those running at the standard 30fps, this issue once again becomes obvious.

So while I seem to have tracked down a culprit build, it seems like this issue was never actually fixed, just made less noticeable.

I did not test the builds between 0.0.5-7096 and 0.0.6-7773, despite there being an evident performance improvement, as I wanted to narrow down where the sudden regression had occurred. I could start going through those, if needed.

@FatheredPuma81
Copy link

FatheredPuma81 commented Oct 1, 2020

Build 0.0.7-8952 (rpcs3-v0.0.7-8952-c16319f9_win64) seems to be the last "working" build, with fps dropping to around 45 at the lowest while attacking. Since the game is typically locked to 30fps, I doubt most people will ever notice the issue is present.

Would just like to say thanks. Reverted to that build for until I finish with Roxas. Would also like to say the issue still persists in 10965. Drops to around 80 FPS FPS in 8952 vs 25 FPS in 10965.
According to another post apparently the cause is his facial animations. When he blinks and when he opens his mouth while swinging.

@pyr0ball
Copy link

pyr0ball commented Oct 1, 2020

I tested Build 0.0.7-8952 with the 60fps patch (using CheatEngine) and the drop is still severe (60fps down to 18-20)

image
image

@FatheredPuma81
Copy link

I tested Build 0.0.7-8952 with the 60fps patch (using CheatEngine) and the drop is still severe (60fps down to 18-20)

Don't use OpenGL. Just tested in Axel fight outside of Usual Spot and OpenGL gets 25 FPS while Vulkan gets 45FPS. Pretty sure in most other area's it stays above 60.

@Skooz
Copy link

Skooz commented Oct 2, 2020

After reviewing the commits & pull request related to build 0.0.7-8956, it seems that enabling "Force CPU blit emulation" under the Debug tab will alleviate this issue, even on the most recent 0.0.12 build; I was not really dropping below 60fps while attacking, which is a tremendous performance improvement. However, it does cause various graphical bugs, and so when enabling "Write Color Buffers" under the GPU tab (as suggested by the CPU blit setting), performance does take a hit, and it drops back down to 40fps or so while attacking. You will still encounter some messed up graphics though, but enabling "Read Color Buffers" under the Advanced tab should solve them.

I suppose I should also note that disabling all of these settings still results in worse performance than having them all on, so it definitely seems related to forcing CPU blit emulation.

Oh, and if you see the sun\lens-flare appearing through buildings\geometry in Twilight Town, that is not because of these settings. It's an upscaling issue with the latest builds. It's unrelated, but I figured I should mention it here so people don't get the wrong idea and assume it's because of this "workaround".

@pyr0ball
Copy link

pyr0ball commented Oct 2, 2020

@FatheredPuma81 Right forgot about that bit. Confirmed on Vulkan the issue is a lot less pronounced:
image
image

The lowest I see it dipping is about 43fps with this build (without applying the changes suggested by Scooz)

@Skooz I did also try 0.0.12 (latest that downloaded yesterday) while enabling those three options I still get the same drop in performance if the read/write buffers, but about the same as 0.0.7-8956 if I ONLY enable "Force CPU blit emulation"

image

@LiLENZO1101
Copy link

first comment here, made this account so i can help with this issue.

i tested both 0.0.5-7772 and 0.0.6-7773, they both have this issue on openGL but not on vulkan. the confusion was caused since darkash assumed the default setting would be vulkan while it was openGL. i will test other versions and see what i can find.

also CPU blit Emulation worked for me (sorta). i was running KH on 60 FPS and with CPU blit i had it running at 30 fps, with the other fixes the performance went to 20 fps only. these readings where taken during combat stance, the game was running at 60 FPS in every other scenario, with or without the CPU blit and the fixes. i'll try to run CPU blit only (without the fixes) and run it without the patch, see if that's playable.

BTW, the issue still remains on build 0.0.13-11371.

tell me what else i should test.

my build is a dell Inspiron 7000 gaming laptop
intel I7-7700HQ
8GB ram
GTX 1050Ti 4GB Vram

@LiLENZO1101
Copy link

update

i tried both 0.0.7-8956 and the one that came before it (0.0.7-8952), and here is what i found

0.0.7-8952 did not have this issue in vulkan
0.0.7-8956 had this issue in vulkan

that, CPU blit test, say that its is a gpu blit issue. (or at least part of it is)

i also tested the newest build, 0.0.13-11371 with only the 30 FPS (60 FPS patch disabled) & CPU blit config (without the fixes) and it gave me playable frame rates. exactly as the 0.0.7-8952 did. they also shared the same FPS fluctuation during an attack animation, it was a steady 30 FPS on the combat stance though. The fluctuation was mostly between 25-30 FPS, and rarely dropped to 20 FPS.

@FatheredPuma81
Copy link

FatheredPuma81 commented Jan 2, 2021

Would just like to drop in with a video of the issue and confirm that CPU Blit Emulation helps but doesn't fix the issue.
Update: Would just like to say I tested OpenGL, Interpreter (Precise), Interpreter (Fast), disabled Multithreaded RSX, and all "Additional Settings" and nothing made a difference.

Ryzen 5 3600, 16GB 3600MHz CL16, GTX 1080

https://youtu.be/9r40nS4_P8I

@LiLENZO1101
Copy link

Would just like to drop in with a video of the issue and confirm that CPU Blit Emulation helps but doesn't fix the issue.
Update: Would just like to say I tested OpenGL, Interpreter (Precise), Interpreter (Fast), disabled Multithreaded RSX, and all "Additional Settings" and nothing made a difference.

Ryzen 5 3600, 16GB 3600MHz CL16, GTX 1080

https://youtu.be/9r40nS4_P8I

hope they see it

@Vandalizar
Copy link

But now is there something that works better than others?
I tried both 0.0.7-8952 and 8956 following @Skooz and @LiLENZO1101, but didn'd work at all, still having a huge drop of fps.
normal
combact

@Skooz
Copy link

Skooz commented Jan 4, 2021

I specifically said that using build 0.0.7-8952 or forcing CPU blit emulation ALLEVIATES the issue. Never said it fixes the issue! Obviously, if your base hardware\performance isn't good enough then you may still drop below 30fps.

At this point, it is up to the RPCS3 devs\contributors to investigate further. I guess they haven't checked in on this thread, so someone will have to nudge them.

@Vandalizar
Copy link

Vandalizar commented Jan 4, 2021

Skooz i wasn't expecting to fix the issues this way, I thought I would have had better performances. I think i'll just speed the roxas part to get to use Sora.

@Sirius902
Copy link

Can confirm this is still an issue in ad49c54.

@ghost
Copy link

ghost commented Mar 27, 2021

Do you think that the soon to be released PC port will shed some light on this issue ? would be interesting to know.
Unless its something PS3 specfic.

@Jay2008p
Copy link
Author

Do you think that the soon to be released PC port will shed some light on this issue ? would be interesting to know.
Unless its something PS3 specfic.

No not at all but since that's coming out i think it would be fair to delete this thread entirely.

@RainbowCookie32
Copy link
Contributor

The issues of a game on the emulator don't go away because it gets released on PC.

@ghost
Copy link

ghost commented Mar 31, 2021

Do you think that the soon to be released PC port will shed some light on this issue ? would be interesting to know.
Unless its something PS3 specfic.

lol looks like I was right and KH2FM is also the problematic game on the PC release... the framerate is all over the place there in some way.
The game drops from 60 to 30 and vice versa on the PC release.

@Darkhost1999
Copy link
Contributor

What information is still needed for this issue if any?

@Skooz
Copy link

Skooz commented Jun 28, 2021

What information is still needed for this issue if any?

Nothing really. My previous posts have laid out the issue as clear as it can be laid out for someone without any experience working on the emulator. It's up to a dev to use this information to see if they can resolve the issue. Of course, it's still possible my findings are totally unhelpful, but there's really nothing else that I or anybody else lacking experience can do at this point. That, and the fact that the 'Force CPU Blit Emulation' setting alleviates the issue could be considered a fix in itself - we may not get any better than that.

That all said, with the franchise now being natively supported on PC, this issue's priority has dropped tenfold. You could try poking one of the devs on Discord or something to look into this issue if you're that desperate, but I'd recommend not bothering with the emulator to begin with if all you're trying to do is play Kingdom Hearts.

@Darkhost1999
Copy link
Contributor

Darkhost1999 commented Dec 9, 2021

Issue is barely even noticeable on anymore. Just turn fps counter off.
https://youtu.be/2mreBQdfTGM
Long ago if I did not enable Force CPU Blit the dip was below 12fps with noticeable consequence to gameplay.
Now you can play like PS3.
RPCS3.log.gz

@kd-11
Copy link
Contributor

kd-11 commented Dec 9, 2021

Let's keep it open for another 48-72h just in case someone is still affected by this one. There have been some major performance optimizations in the past few weeks, it may have been improved by that.

@Megamouse
Copy link
Contributor

I guess the time's up

@FatheredPuma81
Copy link

FatheredPuma81 commented Dec 16, 2021

Oops I missed kd-11's post. The Roxas blinking lag seems to be pretty much fixed and only drops to 200FPS from 360 for me with and without blit enabled. The fighting animation lag persists though and drops to 45FPS without cpu blit and 100FPS with cpu blit.

I "uncapped" the FPS to see if it's 100% gone or not. Should probably get someone with low end hardware that can play the game at like 100 FPS to see how it is.

Video: https://odysee.com/@FatheredPuma81/roxaslag

@Darkhost1999
Copy link
Contributor

Darkhost1999 commented Dec 16, 2021

I see you're complaining about performance loss when using a 60fps patch when the game only natively supports 30 and patches are not an issue for the issue tracker.

Yes there are dips from 30fps to even 22 or 20 fps still present. But it's nowhere near what it was.
If you still got an issue with this issue being closed. Download webman mod. The version after April 1st 2020 play KH on your PS3. But use the FPS overlay ingame and make a comparison video of real ps3 versus RPCS3.

@darkash
Copy link

darkash commented Dec 16, 2021

From my test just now it just drops to 22~25 fps when roxas is attacking while 30 fps while in stance.

previously, it's 20 fps when in stance and gone to crippling single digit when attacking

I got i7-8550U laptop which is weak and the framedrop is still reasonable, so yea it's fixed :D

@FatheredPuma81
Copy link

@Darkhost1999 My point was that the issue is still there and effects the few players that want to play the PS3 version of KH2 instead of the PC version for some reason. If they believe it's fixed enough and want to close it that's up to them.

Also please don't use Recommended specs as a reason why a performance issue isn't an issue. If the performance hit is tied to specs (it doesn't seem to be from @darkash's post) and makes an otherwise playable game unplayable it should still be seen as an issue. Using it to say whether a game is playable, sure, but whether a bug is a bug? No. Not saying you are but I'd just like to point that out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests